Skip to content

Commit a8283d3

Browse files
chmoueltekton-robot
authored andcommittedJan 27, 2025
feat(rpmbuild): update bash-completion handling
- Add bash-completion as a recommended package. - Remove manual generation of bash completion files. - Update changelog to reflect these changes. Fixes #264
1 parent 9b6bc16 commit a8283d3

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎tekton/rpmbuild/tekton.spec

+5-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ License: ASL 2.0
1010
URL: https://%{repo}
1111
Source0: https://%{repo}/archive/tkn_%{version}_Linux_x86_64.tar.gz
1212
Source1: manpages.tar.gz
13+
Recommends: bash-completion
1314

1415
%description
1516
The Tekton Pipelines cli project provides a CLI for interacting with Tekton !
@@ -24,9 +25,6 @@ and not compiling from the sources.
2425
%install
2526
install -D -m 0755 tkn %{buildroot}%{_bindir}/tkn
2627

27-
install -d %{buildroot}%{_datadir}/bash-completion/completions
28-
./tkn completion bash > %{buildroot}%{_datadir}/bash-completion/completions/_tkn
29-
3028
install -d %{buildroot}%{_datadir}/zsh/site-functions
3129
./tkn completion zsh > %{buildroot}%{_datadir}/zsh/site-functions/_tkn
3230

@@ -37,10 +35,13 @@ mkdir -p %{buildroot}%{_mandir} && cp -a man1 %{buildroot}%{_mandir}
3735
%license LICENSE
3836
%{_bindir}/tkn
3937
%{_datadir}/zsh/site-functions/*
40-
%{_datadir}/bash-completion/completions/*
4138
%{_mandir}/*
4239

4340
%changelog
41+
* Mon Jan 08 2022 Chmouel Boudjnah <chmouel@chmouel.com> 0.25.1
42+
- Don't generate bash completion since included by bash-completion package. Add
43+
package as Recommends.
44+
4445
* Mon Jun 13 2022 Chmouel Boudjnah <chmouel@chmouel.com> 0.24.0
4546
- Don't compile, use binary from releases.
4647

0 commit comments

Comments
 (0)