Skip to content

Commit 9f5938b

Browse files
anbaMs2ger
authored andcommitted
Fix harness tests for verifyProperty
1 parent be53234 commit 9f5938b

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

harness/propertyHelper.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,6 @@ function verifyProperty(obj, name, desc, options) {
4545
return true;
4646
}
4747

48-
var names = Object.getOwnPropertyNames(desc);
49-
for (var i = 0; i < names.length; i++) {
50-
assert(
51-
names[i] === "value" ||
52-
names[i] === "writable" ||
53-
names[i] === "enumerable" ||
54-
names[i] === "configurable" ||
55-
names[i] === "get" ||
56-
names[i] === "set",
57-
"Invalid descriptor field: " + names[i],
58-
);
59-
}
60-
6148
assert(
6249
Object.prototype.hasOwnProperty.call(obj, name),
6350
"obj should have an own property " + nameStr
@@ -75,14 +62,27 @@ function verifyProperty(obj, name, desc, options) {
7562
"The desc argument should be an object or undefined, " + String(desc)
7663
);
7764

65+
var names = Object.getOwnPropertyNames(desc);
66+
for (var i = 0; i < names.length; i++) {
67+
assert(
68+
names[i] === "value" ||
69+
names[i] === "writable" ||
70+
names[i] === "enumerable" ||
71+
names[i] === "configurable" ||
72+
names[i] === "get" ||
73+
names[i] === "set",
74+
"Invalid descriptor field: " + names[i],
75+
);
76+
}
77+
7878
var failures = [];
7979

8080
if (Object.prototype.hasOwnProperty.call(desc, 'value')) {
8181
if (!isSameValue(desc.value, originalDesc.value)) {
8282
failures.push("descriptor value should be " + desc.value);
8383
}
8484
if (!isSameValue(desc.value, obj[name])) {
85-
failures.push(failures, "object value should be " + desc.value);
85+
failures.push("object value should be " + desc.value);
8686
}
8787
}
8888

test/harness/verifyProperty-value-error.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ try {
2929
);
3030
}
3131

32-
if (err.message !== 'descriptor value should be 2') {
33-
throw new Error('The error thrown did not define the specified message.');
32+
if (err.message !== 'descriptor value should be 2; object value should be 2') {
33+
throw new Error('The error thrown did not define the specified message');
3434
}
3535
}
3636

0 commit comments

Comments
 (0)