Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent use of language selector icon & other SVG asset problems #300

Open
DerekNonGeneric opened this issue Sep 29, 2022 · 2 comments
Labels
content Related to creating / editing content

Comments

@DerekNonGeneric
Copy link
Contributor

I just took a peek at how the language picker icon is implemented on this site and strangely found it amongst the HTML+Liquid in _layouts/menu.html while all the other SVG assets are located in the assets/img directory. The files located in that directory also have problems. For example, the menu-down.svg icon strangely includes a line indicating that Apple owns the copyright to it (view source).

I also discovered that several other optimizations could significantly reduce the size of all these SVGs. Compare this to a manually optimized one i made a while ago for some other project: https://codepen.io/DerekNonGeneric/pen/bGroexG.

We can even take this a step further by minifying the assets and can probably make additional corrections in the process (viewbox of TC39 logo seems off) and we should probably ensure all are following a11y best practices (accessible SVGs).

@smorimoto
Copy link
Member

I'm interested in improving around assets. It would be great to open a PR to lift us up to the first stage, but are you willing to do that? I'd love to see that.

@DerekNonGeneric
Copy link
Contributor Author

Yeah, will get to it eventually (glad you agree) 😄

@smorimoto smorimoto added the content Related to creating / editing content label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Related to creating / editing content
Projects
None yet
Development

No branches or pull requests

2 participants