Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal (searching on the site) #120

Open
RinatValiullov opened this issue Mar 9, 2019 · 5 comments
Open

Proposal (searching on the site) #120

RinatValiullov opened this issue Mar 9, 2019 · 5 comments
Labels
discussion Idea / Issue that needs to be discussed first enhancement New feature or request

Comments

@RinatValiullov
Copy link

I think it would be great and more accessible provide some search on the site. There are rather many features and it's not convinient listing to the bottom for reveal needed one.

@codehag
Copy link
Collaborator

codehag commented Mar 9, 2019

Thanks for the comment, I think I understand where you are coming from. The bottom link of the page suggests that we have pagination, and that there are more proposals available from this portal -- but this isn't the case. We are only surfacing the stage 3 proposals, and there are only 10 of them. I think if we were listing more than 10 proposals and we had pagination, this would make sense. In case it is unclear what I mean, if you use ctrl-f (or command-f on mac) in the browser, it will immediately surface the same information that we would achieve by introducing a search directly on the site. Both from a technical standpoint, and a usability standpoint, it doesn't make sense to introduce an in-site search as it would be redundant to browser functionality.

This does not mean that we will not have a search. In the future, if we have more proposals available (for example stage 2 or stage 1) -- or in another use case -- we have more documentation and we want to make it easy to find (this is planned), it is likely we will start thinking about search. Your suggestion is for sure useful, but it might be implemented at a later date.

@codehag codehag added enhancement New feature or request discussion Idea / Issue that needs to be discussed first labels Mar 9, 2019
@RinatValiullov
Copy link
Author

RinatValiullov commented Mar 9, 2019

@codehag
Ok. Thanks for clear and exhaustive answer.
Should I close this issue or save it for later changes?

@codehag
Copy link
Collaborator

codehag commented Mar 9, 2019

Lets leave it open for now, I will pass through the issues and collect v2 suggestions, and it can be easy to forget things.

@xtuc
Copy link
Member

xtuc commented Mar 11, 2019

We can cc search friends for suggestions @Haroenv

@Haroenv
Copy link

Haroenv commented Mar 11, 2019

Things that a search would be useful for:

  • proposal name
  • proposal text or alternative name (would be impractical with cmd-f, but easily achievable with a real search)
  • general search for the other things linked to in the header. This could be done by crawling the the linked GitHub pages in e.g. a build process or daily

By the way, Algolia would definitely be interested in helping to set up the search here free of charge, with a small logo, like on Babel or React's sites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Idea / Issue that needs to be discussed first enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants