Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Example indicator #105

Open
codehag opened this issue Mar 4, 2019 · 1 comment
Open

Show Example indicator #105

codehag opened this issue Mar 4, 2019 · 1 comment
Labels
design

Comments

@codehag
Copy link
Collaborator

codehag commented Mar 4, 2019

For examples, we add a section that says "show example" which indicates that clicking it will expand into a long code block:

This was mentioned in #101

It is currently not ideal. If anyone has ideas about how to adjust this, let's iterate on it. I tried what was suggested in #101, but I found that pulling it to the right moved it out of sight line when reading the descriptions.

Current version:

screenshot 2019-03-04 at 14 33 19

Closed
screenshot 2019-03-04 at 14 31 43

Open
screenshot 2019-03-04 at 14 31 37
@codehag codehag changed the title Show Example Show Example indicator Mar 4, 2019
@codehag codehag added the design label Mar 4, 2019
@ljharb
Copy link
Member

ljharb commented Mar 5, 2019

This could use a details tag, whether it starts open or closed.

@michaelficarra michaelficarra mentioned this issue Mar 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @codehag