-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourceURL
in non-eval
sources
#125
Comments
It does look to conflict a bit. I think we can loosen or remove the first link and have it not mention |
yeah, I think it is would be great to indicate that |
Turbopack uses both when
|
@legendecas @jridgewell thank you for the context! What is safe to say in the spec? I'd like to remove the |
Yah, removing references to "eval" seems good to me. See also https://bloomberg.github.io/ts-blank-space/ which is using |
@legendecas can give more info, but it looks like Node.js is using
//#sourceURL
to map "virtual" files (created by transpiling TS on-the-fly) to their original filenames, without using a full source map. This is possible because in their implementation all the JS tokens are still in the original position, so mapping locations is not actually needed.Does our spec support this use case, or does it only support the comment in
eval()
? In https://tc39.es/source-map/#linking-evald-code-to-named-generated-code says that it's foreval()
'ed code, while in https://tc39.es/source-map/#linking-generated-code it also mentions it for "normal scripts".The text was updated successfully, but these errors were encountered: