Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 implementation feedback to ICU team #2196

Open
FrankYFTang opened this issue May 13, 2022 · 4 comments
Open

v8 implementation feedback to ICU team #2196

FrankYFTang opened this issue May 13, 2022 · 4 comments
Labels
Milestone

Comments

@FrankYFTang
Copy link
Contributor

Just to tracks issues I report to ICU team while I attemp to implement the intl support of Temporal.Calendar by using ICU 71-1

Slides https://docs.google.com/presentation/d/1xDQAd_64rjjXOIGeFFWafRWWC8Yn6L2v_RgxVbj-Y0Y/edit#slide=id.g128864141cc_0_41
I also proposal additional changes to ICU 72-1. The shape of the API may be changed by ICU TC next Thursday but I think the doc show the reason why I need to make such proposal. It will be very hard to implement Temporal.Calendar (in particular for ChineseCalendar, DangiCalendar, and HebrewCalendar ) w/o these changes.
Also see how ugly (those option A in my slide) if we use the 71-1 API to implement it.
https://docs.google.com/document/d/1Zts_kWWniA_SnVBguSwjfpyiZxtZ7m3mVnLYbmXhmhM/edit#

@FrankYFTang
Copy link
Contributor Author

@sffc @ryzokuken @anba

@FrankYFTang
Copy link
Contributor Author

The ICU ticket is https://unicode-org.atlassian.net/browse/ICU-22027

@ptomato
Copy link
Collaborator

ptomato commented May 13, 2022

I will look into this in more detail later, but what jumped out at me is that if you are adding Temporal month codes for leap months to ICU, they should be like M05L, not L05.

@FrankYFTang
Copy link
Contributor Author

I will look into this in more detail later, but what jumped out at me is that if you are adding Temporal month codes for leap months to ICU, they should be like M05L, not L05.

I am so glad you capture this issue. I somehow mentally always though it was L05 but you are right, it should be M05L. I will correct them ASAP.

@ptomato ptomato added this to the Stage 4 milestone Dec 8, 2022
@ptomato ptomato added the meta label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants