Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit assertions that something is an integer #1467

Closed
ptomato opened this issue Apr 1, 2021 · 2 comments
Closed

Audit assertions that something is an integer #1467

ptomato opened this issue Apr 1, 2021 · 2 comments
Assignees
@ptomato
Labels
spec-text Specification text involved tc39-review
Milestone
Stage 4

Comments

@ptomato
Copy link
Collaborator

ptomato commented Apr 1, 2021

These assertions are probably misunderstandings left over from before ToInteger was renamed to ToIntegerOrInfinity. In most cases it is probably OK to handle infinity as well. Audit all such assertions and determine whether they should handle infinities.

(Follow up from #1426 (comment))
@ptomato ptomato added spec-text Specification text involved tc39-review labels Apr 1, 2021
@ptomato ptomato added this to the Stage 3 Conditional milestone Apr 1, 2021
@ptomato ptomato mentioned this issue Apr 1, 2021
Closed
@ptomato ptomato modified the milestones: Stage 3 Conditional, Next May 12, 2021
@ptomato ptomato mentioned this issue Jul 13, 2021
Closed
@ptomato
Copy link
Collaborator Author

ptomato commented Jul 13, 2021

Note (from duplicate issue #1635) that as per the conclusion in #1229 (comment), PrepareTemporalFields should throw on infinities, so in some cases the assertions should remain the same but the steps before them should change.

FrankYFTang added a commit to FrankYFTang/proposal-temporal that referenced this issue Jul 14, 2021
@FrankYFTang
Throw Range in PrepareTemporalFields for +∞ or -∞
ac65f4a 
Fix one of the issue in tc39#1467
@FrankYFTang FrankYFTang mentioned this issue Jul 14, 2021
Merged
ptomato pushed a commit to FrankYFTang/proposal-temporal that referenced this issue Aug 12, 2021
@FrankYFTang @ptomato
Throw RangeError in PrepareTemporalFields for +∞ or -∞
00756b3 
Fix one of the issue in tc39#1467
ptomato pushed a commit to FrankYFTang/proposal-temporal that referenced this issue Aug 17, 2021
@FrankYFTang @ptomato
Throw RangeError in PrepareTemporalFields for +∞ or -∞
6de380b 
Fix one of the issue in tc39#1467
ptomato pushed a commit that referenced this issue Aug 31, 2021
@FrankYFTang @ptomato
Throw RangeError in PrepareTemporalFields for +∞ or -∞
499282a 
Fix one of the issue in #1467
@ptomato ptomato modified the milestones: Next, Stage 4 Dec 8, 2022
@ptomato
Copy link
Collaborator Author

ptomato commented Dec 8, 2022

Verify whether this is already resolved, and close if so.

@ptomato ptomato self-assigned this Mar 26, 2024
ptomato added a commit that referenced this issue Mar 26, 2024
@ptomato
Editorial: Structured header for PadISOYear
fd26bb1 
While looking for "is an integer" assertions (#1467), I decided to remove
this one by converting the AO to have a structured header.
Ms2ger pushed a commit that referenced this issue Mar 28, 2024
@ptomato @Ms2ger
Editorial: Structured header for PadISOYear
82fa576 
While looking for "is an integer" assertions (#1467), I decided to remove
this one by converting the AO to have a structured header.
ptomato added a commit that referenced this issue Apr 17, 2024
@ptomato
Editorial: Don't use ToIntegerOrInfinity for string parsing
a8d8a6b 
ECMA-262 settled on ℝ(StringToNumber(CodePointsToString(foo))) as the
proper way to do this in ParseTimeZoneOffsetString. Adopt this in the
Temporal spec as well, with a similar note about precision.

This removes all uses of ToIntegerOrInfinity, so the issue about auditing
all uses of it to make sure they handle infinities correctly can be closed
as well.

Closes: #1566
Closes: #1467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
spec-text Specification text involved tc39-review
Projects
None yet
Milestone
Stage 4
Development

No branches or pull requests
1 participant
@ptomato