-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted lines should not be considered to return a completion record from an AO #609
Comments
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this issue
Sep 12, 2024
It can no longer throw, but we didn't notice that because of a bug in ecmarkup (tc39/ecmarkup#609). Change the return type, adjust the call sites not to unwrap the completion, and work around the ecmarkup bug with an editor's note and by putting the offending line in backticks so that ecmarkup doesn't consider it semantically.
This was referenced Sep 17, 2024
Merged
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this issue
Sep 18, 2024
It can no longer throw, but we didn't notice that because of a bug in ecmarkup (tc39/ecmarkup#609). Change the return type, adjust the call sites not to unwrap the completion, and work around the ecmarkup bug with an editor's note and by putting the offending line in backticks so that ecmarkup doesn't consider it semantically.
Ms2ger
pushed a commit
to tc39/proposal-temporal
that referenced
this issue
Sep 19, 2024
It can no longer throw, but we didn't notice that because of a bug in ecmarkup (tc39/ecmarkup#609). Change the return type, adjust the call sites not to unwrap the completion, and work around the ecmarkup bug with an editor's note and by putting the offending line in backticks so that ecmarkup doesn't consider it semantically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test case:
This produces:
Looks like there is something that needs to be handled differently about the structured header return type, as well.
The text was updated successfully, but these errors were encountered: