Skip to content

Commit 3e344ff

Browse files
StefanStojanovictargos
authored andcommitted
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs#56238 Refs: nodejs#55784 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> PR-URL: nodejs#55014 Reviewed-By: Matteo Collina <[email protected]>
1 parent 2464533 commit 3e344ff

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.6',
41+
'v8_embedder_string': '-node.7',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/include/v8config.h

+4
Original file line numberDiff line numberDiff line change
@@ -591,11 +591,15 @@ path. Add it with -I<path> to the command line
591591
// functions.
592592
// Use like:
593593
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
594+
#if V8_OS_WIN
595+
# define V8_PRESERVE_MOST
596+
#else
594597
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
595598
# define V8_PRESERVE_MOST __attribute__((preserve_most))
596599
#else
597600
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
598601
#endif
602+
#endif
599603

600604

601605
// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.

0 commit comments

Comments
 (0)