fix: #258

Author: taoqf

src/nodes/html.ts

@@ -718,9 +718,7 @@ export default class HTMLElement extends Node {
 		this.rawAttrs = Object.keys(attrs)
 			.map((name) => {
 				const val = this.quoteAttribute(attrs[name]);
-				if (val === undefined || val === 'null') {
-					return name;
-				}
+				if (val === 'null' || val === '""') return name;
 				return `${name}=${val}`;
 			})
 			.join(' ');

test/tests/issues/258.js

@@ -0,0 +1,16 @@
+const { parse } = require('@test/test-target');
+
+describe('issue 258', function () {
+	it('removeAttribute makes boolean attributes render incorrectly.', function () {
+		const inputEl = parse('<input>').firstChild
+
+		inputEl.setAttribute('checked', '');
+		inputEl.setAttribute('a', '');
+		inputEl.toString().should.eql('<input checked a>');
+
+		inputEl.removeAttribute('a');
+		inputEl.toString().should.eql('<input checked>');
+		console.log(inputEl.toString()); // => <input checked=""> INCORRECT
+		// div.innerText.should.eql(`Hello World`);
+	});
+});