Skip to content

Commit 364b24b

Browse files
committed
floating point values for priority style param
- floating point values for priority will be used soon once tilezen/vector-datasource#988 lands in tilzen tiles
1 parent e4ebb42 commit 364b24b

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

core/src/scene/styleContext.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,8 @@ bool StyleContext::evalStyle(FunctionID _id, StyleParamKey _key, StyleParam::Val
313313
break;
314314
}
315315
case StyleParamKey::angle:
316+
case StyleParamKey::priority:
317+
case StyleParamKey::text_priority:
316318
case StyleParamKey::text_font_stroke_width:
317319
case StyleParamKey::placement_min_length_ratio: {
318320
_val = static_cast<float>(number);
@@ -326,7 +328,6 @@ bool StyleContext::evalStyle(FunctionID _id, StyleParamKey _key, StyleParam::Val
326328
}
327329
case StyleParamKey::order:
328330
case StyleParamKey::outline_order:
329-
case StyleParamKey::priority:
330331
case StyleParamKey::color:
331332
case StyleParamKey::outline_color:
332333
case StyleParamKey::text_font_fill:

core/src/scene/styleParam.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,7 @@ StyleParam::Value StyleParam::parseNode(StyleParamKey key, const YAML::Node& nod
285285
break;
286286
case StyleParamKey::order:
287287
case StyleParamKey::outline_order:
288-
case StyleParamKey::priority:
289-
case StyleParamKey::text_max_lines:
290-
case StyleParamKey::text_priority: {
288+
case StyleParamKey::text_max_lines: {
291289
int result = -1;
292290
if (YamlUtil::getInt(node, result)) {
293291
return static_cast<uint32_t>(result);
@@ -350,6 +348,8 @@ StyleParam::Value StyleParam::parseNode(StyleParamKey key, const YAML::Node& nod
350348
LOGW("Invalid angle value: %s", Dump(node).c_str());
351349
break;
352350
}
351+
case StyleParamKey::priority:
352+
case StyleParamKey::text_priority:
353353
case StyleParamKey::miter_limit:
354354
case StyleParamKey::outline_miter_limit:
355355
case StyleParamKey::placement_min_length_ratio:
@@ -477,9 +477,7 @@ std::string StyleParam::toString() const {
477477
case StyleParamKey::order:
478478
case StyleParamKey::text_order:
479479
case StyleParamKey::outline_order:
480-
case StyleParamKey::priority:
481480
case StyleParamKey::text_max_lines:
482-
case StyleParamKey::text_priority:
483481
case StyleParamKey::color:
484482
case StyleParamKey::outline_color:
485483
case StyleParamKey::outline_style:
@@ -493,6 +491,8 @@ std::string StyleParam::toString() const {
493491
case StyleParamKey::outline_join:
494492
if (!value.is<uint32_t>()) break;
495493
return k + std::to_string(value.get<uint32_t>());
494+
case StyleParamKey::priority:
495+
case StyleParamKey::text_priority:
496496
case StyleParamKey::miter_limit:
497497
case StyleParamKey::angle:
498498
case StyleParamKey::outline_miter_limit:

core/src/style/pointStyleBuilder.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,12 @@ auto PointStyleBuilder::applyRule(const DrawRule& _rule) const -> Parameters {
131131
_rule.get(StyleParamKey::offset, p.labelOptions.offset);
132132
_rule.get(StyleParamKey::buffer, p.labelOptions.buffer);
133133

134-
uint32_t priority = 0;
134+
float priority = 0;
135135
std::string repeatGroup;
136136
StyleParam::Width repeatDistance;
137137

138138
if (_rule.get(StyleParamKey::priority, priority)) {
139-
p.labelOptions.priority = (float)priority;
139+
p.labelOptions.priority = priority;
140140
}
141141

142142
_rule.get(StyleParamKey::sprite_default, p.spriteDefault);

core/src/style/textStyleBuilder.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -618,15 +618,15 @@ TextStyle::Parameters TextStyleBuilder::applyRule(const DrawRule& _rule,
618618

619619
_rule.get(StyleParamKey::text_max_lines, p.maxLines);
620620

621-
uint32_t priority = 0;
621+
float priority = 0;
622622
size_t repeatGroupHash = 0;
623623
std::string repeatGroup;
624624
StyleParam::Width repeatDistance;
625625
glm::vec2 defaultBuffer = glm::vec2(p.fontSize * 0.25f);
626626

627627
if (_iconText) {
628628
if (_rule.get(StyleParamKey::text_priority, priority)) {
629-
p.labelOptions.priority = (float)priority;
629+
p.labelOptions.priority = priority;
630630
}
631631
_rule.get(StyleParamKey::text_collide, p.labelOptions.collide);
632632
if (!_rule.get(StyleParamKey::text_interactive, p.interactive)) {
@@ -668,7 +668,7 @@ TextStyle::Parameters TextStyleBuilder::applyRule(const DrawRule& _rule,
668668
}
669669
} else {
670670
if (_rule.get(StyleParamKey::priority, priority)) {
671-
p.labelOptions.priority = (float)priority;
671+
p.labelOptions.priority = priority;
672672
}
673673
_rule.get(StyleParamKey::collide, p.labelOptions.collide);
674674
_rule.get(StyleParamKey::interactive, p.interactive);

0 commit comments

Comments
 (0)