Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make settings be an object so we are able to use it through PSQL or TOML #172

Open
vmesel opened this issue Apr 5, 2024 · 2 comments
Open

Make settings be an object so we are able to use it through PSQL or TOML #172

vmesel opened this issue Apr 5, 2024 · 2 comments

Comments

@vmesel
Copy link
Member

vmesel commented Apr 5, 2024

No description provided.

@lgabs
Copy link
Collaborator

lgabs commented Apr 5, 2024

what object it would be? One of these days I was thing about pydantic settings, any ideas on that? Langserve uses pydantic as well, so that's why I was looking at this.

@vmesel
Copy link
Member Author

vmesel commented Apr 7, 2024

@lgabs so I took a look at your ragtalk repo and I really enjoyed your implementation of the settings object, I've made a change on #171 that bumps the settings of the project to an object, but it's not the best approach ever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmesel @lgabs