[Turbo] Add stream format with request listener #2550
Merged
+96
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleho
force-pushed
the
fix/turbo-stream-format-workers
branch
from
a770555 to
2d28de2
Compare
|
The failing tests are in LiveComponents and a timeout in webdriver. I hope they're not related to my changes ;). |
|
Hi @aleho ! Thank you for this PR :) Do you think you could add a small test to prevent any future regression? |
smnandre
added
Status: Reviewing
aleho
force-pushed
the
fix/turbo-stream-format-workers
branch
from
2d28de2 to
ae70cf2
Compare
BundleInterface::boot() is only called when booting a worker and not on every request. Fixes symfony#2549
aleho
force-pushed
the
fix/turbo-stream-format-workers
branch
from
ae70cf2 to
91b8268
Compare
|
@smnandre I wasn't entirely sure how to test that. Is "simulating" a worker mode by not re-booting the kernel enough? |
|
Thanks @aleho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BundleInterface::boot() is only called when booting a worker and not on every request. So on FrankenPHP for example Turbo requests would never return a stream when checking with
if ($request->getPreferredFormat() === TurboBundle::STREAM_FORMAT.This replaces
TurboBundle::boot()with a request listener to register the format on every request.