[ObjectMapper] Add component #20347
[ObjectMapper] Add component #20347
Conversation
OskarStark
changed the title
object-mapper.rst
Outdated
| /** | ||
| * @implements CallableInterface<Source> | ||
| */ |
There was a problem hiding this comment.
Is this necessary in a documentation example ?
There was a problem hiding this comment.
I think that its best to have a copy/paste that doesn't trigger phpstan errors
object-mapper.rst
Outdated
| // src/Dto/Source.php | ||
| namespace App\Dto; | ||
|
|
||
| use App\ObjectMapper\TransformNameCallable; |
There was a problem hiding this comment.
This use statement doesn't seem used in this example
object-mapper.rst
Outdated
| Using the ObjectMapper Service | ||
| ------------------------------ | ||
|
|
||
| Once enabled, the object mapper service can be injected in any service where |
There was a problem hiding this comment.
Once installed ?
because writing enabled can mean that it is not enabled:usable by default after installation
object-mapper.rst
Outdated
| $mapper->map(source: new Source(), target: Target::class); | ||
|
|
||
|
|
||
| If you alread have a target object, you can use its instance directly:: |
There was a problem hiding this comment.
| If you alread have a target object, you can use its instance directly:: | |
| If you already have a target object, you can use its instance directly:: |
Small typo. Not related question, can we expect APP with ObjectMapper DTO support or it's just works now?
Also, this probably needs to target 7.3.
Thanks!
object-mapper.rst
Outdated
| #[Map(target: C::class, if: [Source::class, 'shouldMapToC'])] | ||
| class Source | ||
| { | ||
| public static function shouldMapToB(mixed $value, object $object): bool |
There was a problem hiding this comment.
Which are the mixed $value, object $object arguments passed to this method?
| use Symfony\Component\ObjectMapper\Attributes\Map; | ||
|
|
||
| class Source { | ||
| #[Map(target: 'fullName', transform: TransformNameCallable::class)] |
There was a problem hiding this comment.
Can I use a transform for the entire object instead of for each of its properties?
| #[Map(target: 'fullName')] | ||
| public string $firstName; | ||
|
|
||
| #[Map(if: false)] |
There was a problem hiding this comment.
What does #[Map(if: false)] mean here? To me, "map if false" means "copy this value to the other object only if it's false". Not sure if that's what we want to do here.
There was a problem hiding this comment.
The if property could have a dedicated section.
It is mentioned below that it can be a boolean, a class-string a callable or a closure.
IMHO all the cases could be explained.
OskarStark
changed the title
|
CI should be green after a rebase on |
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\ObjectMapper\ObjectMapperInterface; | ||
|
|
||
| class DefaultController extends AbstractController |
There was a problem hiding this comment.
As this is a demo code, wdyt using invokable controller? Make code more straight forward to me
object-mapper.rst
Outdated
|
|
||
| To map an object to another one use ``map``:: | ||
|
|
||
| use App\Dto\Source; |
There was a problem hiding this comment.
Genuine question : Dto\ or \Model ?
There was a problem hiding this comment.
Dto is in my opinion more generic, or what about ValueObject?
object-mapper.rst
Outdated
|
|
||
| $target = new Target(); | ||
| $mapper = new ObjectMapper(); | ||
| $mapper->map(source: new Source(), target: $target); |
There was a problem hiding this comment.
Named param must be remove from doc
There was a problem hiding this comment.
Instead of objA objB
wdyt using « real » code example?
there are plenty sf doc code with such example one can write/understand to avoid brainswitch
There was a problem hiding this comment.
yes please use real world use cases
object-mapper.rst
Outdated
|
|
||
| Symfony provides a mapper to transform a given object to another one. | ||
|
|
||
| .. _activating_the_serializer: |
|
I've rebased, this also documents symfony/symfony#60028 as it's quite mandatory for many real world use cases. Interfaces are now matching the merged code. At the beginning I've used real word examples @94noni could you let me know your thoughts and if you think I should apply the same logic accross the whole documentation? |
| } | ||
|
|
||
| // src/Dto/Source.php |
There was a problem hiding this comment.
| } | |
| // src/Dto/Source.php | |
| } | |
| :: | |
| // src/Dto/Source.php |
this should fix the Please reorder the use statements alphabetically error
Documents the object mapper component from