Skip to content

Commit e86f855

Browse files
bug #57853 [Console] Fix side-effects from running bash completions (Seldaek)
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix side-effects from running bash completions | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix composer/composer#12015 | License | MIT Fixes issues in symfony bash completions having side-effects for other completions. See composer/composer#12015 for details. I identified this IFS line as causing the issue.. But it was introduced here symfony/symfony@e9e0c07 (cc `@GromNaN`) probably for a good reason. So I don't think this is mergeable as is, but we should see what can be done to set IFS where needed per process call and not change it globally like that. Commits ------- 5456645628 [Console] Fix side-effects from running bash completions
2 parents f96ee2a + c24bcd0 commit e86f855

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: Resources/completion.bash

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
_sf_{{ COMMAND_NAME }}() {
99
# Use newline as only separator to allow space in completion values
10-
IFS=$'\n'
10+
local IFS=$'\n'
1111
local sf_cmd="${COMP_WORDS[0]}"
1212

1313
# for an alias, get the real script behind it

0 commit comments

Comments
 (0)