From 6742ed1b50ef854b151fe3c4b87e03bd4f890b98 Mon Sep 17 00:00:00 2001
From: Rick Newton-Rogers <rnro@apple.com>
Date: Fri, 7 Mar 2025 13:16:02 +0000
Subject: [PATCH 1/2] Only apply standard swift settings on valid targets
---
Package.swift | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Package.swift b/Package.swift
index 46e38fe..69a6375 100644
--- a/Package.swift
+++ b/Package.swift
@@ -19,8 +19,7 @@ import PackageDescription
let swiftSettings: [SwiftSetting] = [
// https://github.com/apple/swift-evolution/blob/main/proposals/0335-existential-any.md
// Require `any` for existential types.
- .enableUpcomingFeature("ExistentialAny"),
- .enableExperimentalFeature("StrictConcurrency=complete"),
+ .enableUpcomingFeature("ExistentialAny"), .enableExperimentalFeature("StrictConcurrency=complete"),
]
let package = Package(
@@ -54,11 +53,13 @@ let package = Package(
// --- STANDARD CROSS-REPO SETTINGS DO NOT EDIT --- //
for target in package.targets {
- if target.type != .plugin {
+ switch target.type {
+ case .regular, .test, .executable:
var settings = target.swiftSettings ?? []
// https://github.com/swiftlang/swift-evolution/blob/main/proposals/0444-member-import-visibility.md
settings.append(.enableUpcomingFeature("MemberImportVisibility"))
target.swiftSettings = settings
+ case .macro, .plugin, .system, .binary: () // not applicable
+ @unknown default: () // we don't know what to do here, do nothing
}
-}
-// --- END: STANDARD CROSS-REPO SETTINGS DO NOT EDIT --- //
+}// --- END: STANDARD CROSS-REPO SETTINGS DO NOT EDIT --- //
From f89f14882ffdf6714855707e7b6879d636c36e3a Mon Sep 17 00:00:00 2001
From: Rick Newton-Rogers <rnro@apple.com>
Date: Fri, 7 Mar 2025 13:20:52 +0000
Subject: [PATCH 2/2] Apply suggestions from code review
Undo formatting changes
---
Package.swift | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Package.swift b/Package.swift
index 69a6375..85fcb5d 100644
--- a/Package.swift
+++ b/Package.swift
@@ -19,7 +19,8 @@ import PackageDescription
let swiftSettings: [SwiftSetting] = [
// https://github.com/apple/swift-evolution/blob/main/proposals/0335-existential-any.md
// Require `any` for existential types.
- .enableUpcomingFeature("ExistentialAny"), .enableExperimentalFeature("StrictConcurrency=complete"),
+ .enableUpcomingFeature("ExistentialAny"),
+ .enableExperimentalFeature("StrictConcurrency=complete"),
]
let package = Package(
@@ -62,4 +63,5 @@ for target in package.targets {
case .macro, .plugin, .system, .binary: () // not applicable
@unknown default: () // we don't know what to do here, do nothing
}
-}// --- END: STANDARD CROSS-REPO SETTINGS DO NOT EDIT --- //
+}
+// --- END: STANDARD CROSS-REPO SETTINGS DO NOT EDIT --- //