Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of new Configuration API into project #43

Closed
felixschlegel opened this issue Dec 21, 2022 · 0 comments
Closed

Integration of new Configuration API into project #43

felixschlegel opened this issue Dec 21, 2022 · 0 comments

Comments

@felixschlegel
Copy link
Contributor

felixschlegel commented Dec 21, 2022 •
edited
Loading

New configuration API already implemented in #42.

  • Refactor KafkaClients into using the new configuration types (ConsumerConfig, ProducerConfig and TopicConfig)
  • deprecate the legacy configuration type
  • ideally: remove KafkaConfig (alongside its tests) and initialise librdkafka config inside of KafkaClient
  • KafkaConsumer: determine if consumer is assigned or subscribed through ConsumerConfig
  • enable passing topics through the ClientConfig instead of theinit of KafkaConsumer
  • make tests use new configuration API
  • update README to use new configuration API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felixschlegel