Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterUpdate docs should mention recursion protection #2778

Closed
chris-morgan opened this issue May 16, 2019 · 2 comments
Closed

afterUpdate docs should mention recursion protection #2778

chris-morgan opened this issue May 16, 2019 · 2 comments

Comments

@chris-morgan
Copy link
Contributor

In src/internal/scheduler.js, flush() protects against recursion caused by afterUpdate with its seen_callbacks variable.

This may lead to surprising behaviour, if the user depends on multiple but finite invocations of their afterUpdate callback, so it should be documented.

@stale
Copy link

stale bot commented Dec 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 26, 2021
@Conduitry
Copy link
Member

afterUpdate() has been deprecated in favor of $effect(), so I'm going to close this.

@Conduitry Conduitry closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants