-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restarting Language server spawns new output channel #2721
Comments
Did you just want to not have multiple "svelte" in the output channel? Our restart implementation is before vscode-languageclient added the restart method. But even if we use the "restart" method it provides, it would also not "reuse" the process and the output channel. Just it won't have multiple entries. Is this what you wanted? |
It's not what I would expect, I would expect there to only be one so that I don't have to find the one that's currently working. |
I am not sure which part isn't what you expect but sounds like you only care about seeing multiple svelte output channels. I was trying to say that you can't restart without creating a new child process. The output channel will also not be the same, but there won't be multiple "svelte" outputs. |
@jasonlyu123 I would not expect there to be multiple output channels but sounds like you only care about about what you know. I don't know anything about the ins/outs of how the language server works, and i'm just trying to help. So please don't make unhelpful comments. I have literally included a video |
I don't know what you mean by "process". That's why I linked a wiki page to mention what I meant by "process". I am just trying to confirm what you are saying since the term you're using doesn't make sense to me. If your "process" just means "output channel' then I get what you meant. But if it meant the actual language server "process (computing)" then it is a completely different story. |
Describe the bug
Running "Svelte: Restart Language Server" in VSCode spawns an additional svelte process shown in the output without clearing the old one
Reproduction
Given the user has "Svelte for VS Code" installed.
And the user has opened a
.svelte
file. (Starts initial process)When the user runs the VSCode command "Svelte: Restart Language Server"
Then an additional "svelte" process starts while the old process reads: "[Error - 09:22:17] Server process exited with code 0."
Expected behaviour
Given the user has "Svelte for VS Code" installed.
And the user has opened a
.svelte
file. (Starts initial process)When the user runs the VSCode command "Svelte: Restart Language Server"
Then the existing process is re-used or discarded
System Info
OS: MacOS 15.3.2 (24D81)
IDE: VSCode
Version: 1.98.2
Commit: ddc367ed5c8936efe395cffeec279b04ffd7db78
Date: 2025-03-12T13:32:45.399Z
Electron: 34.2.0
ElectronBuildId: 11161602
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Darwin arm64 24.3.0
Plugin:
Name: Svelte for VS Code
Id: svelte.svelte-vscode
Description: Svelte language support for VS Code
Version: 109.5.3
Publisher: Svelte
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=svelte.svelte-vscode
Which package is the issue about?
No response
Additional Information, eg. Screenshots
Screen.Recording.2025-03-23.at.09.13.34.mov
The text was updated successfully, but these errors were encountered: