Separate doc filtration and reasoning LLMs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1 Separate the document filtration and reasoning LLMs into two distinct models. * **Python Changes:** - Add a new parameter `filtration_model` to the `ReagClient` constructor in `python/src/reag/client.py`. - Update the `query` method to use the `filtration_model` for document filtration and the `model` for generating the final answer. - Update `python/README.md` to reflect the changes in the `ReagClient` class and the new two-step process. * **TypeScript Changes:** - Add a new parameter `filtrationModel` to the `ReagClient` constructor in `typescript/src/client.ts`. - Update the `query` method to use the `filtrationModel` for document filtration and the `model` for generating the final answer. - Update `typescript/README.md` to reflect the changes in the `ReagClient` class and the new two-step process. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/superagent-ai/reag/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
|
@jasonkneen thanks for the contribution will check test and merge. |
|
@jasonkneen mind fixing the merge conflicts? |
homanp
requested changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Separate the document filtration and reasoning LLMs into two distinct models.
Python Changes:
filtration_modelto theReagClientconstructor inpython/src/reag/client.py.querymethod to use thefiltration_modelfor document filtration and themodelfor generating the final answer.python/README.mdto reflect the changes in theReagClientclass and the new two-step process.TypeScript Changes:
filtrationModelto theReagClientconstructor intypescript/src/client.ts.querymethod to use thefiltrationModelfor document filtration and themodelfor generating the final answer.typescript/README.mdto reflect the changes in theReagClientclass and the new two-step process.For more details, open the Copilot Workspace session.