-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pnpm #459
Comments
Digging more into this, pnpm installs all the nested node_modules in .pnpm and resolves modules a bit differently. I will have to understand it better to support the type of augmentation done here. |
@qballer any news? |
I thought about maybe reusing the |
Hi, I'm using pnpm and i'm not able to import
|
Hi @kyrregjerstad, please see this: https://suites.dev/docs/overview/installation/#for-yarn-v1x-users Realtes #473 (reply in thread) Let me know if it worked :) |
Hi @omermorad, thanks for the quick reply! I tried following the yarn install guide without any luck. I discovered that the issue stems from using TypeScript's newer Here's the working tsconfig.json configuration: {
"compilerOptions": {
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"moduleResolution": "node"
},
"include": ["src/**/*", "./global.d.ts"]
} Would it be possible to add support for the bundler moduleResolution in a future release? This would help developers using modern bundlers like Vite/webpack and align with TypeScript's recommended settings for newer projects. Let me know if you'd like me to create a separate feature request issue for this enhancement. |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe it
The project's current post-install scripts to get augmentation to work assume a hoisted node_modules system like in yarn and npm. This breaks when using PNPM install
Describe the solution you'd like
To get support for PNPM, the post-install script will need to support both hoisted and nested packages.
Specifically, lines like:
https://github.com/suites-dev/suites/blob/master/packages/di/nestjs/postinstall.js#L4
https://github.com/suites-dev/suites/blob/master/packages/di/inversify/postinstall.js#L4
And:
https://github.com/suites-dev/suites/blob/master/packages/doubles/jest/postinstall.js#L4-L7
https://github.com/suites-dev/suites/blob/master/packages/doubles/sinon/postinstall.js#L4-L7
https://github.com/suites-dev/suites/blob/master/packages/doubles/vitest/postinstall.mjs#L8-L11
Those post-install scripts will need to change in a way that allows them to detect
dist
folders (in suites repo), hoisted packages(Yarn and NPM), and nested packages (PNPM).What is the motivation / use case for changing the behavior?
support PNPM
The text was updated successfully, but these errors were encountered: