Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PitchSlider overlaps with Blocks when using Up and Down arrow keys #4466

Closed
4 tasks done
Ubayed-Bin-Sufian opened this issue Feb 27, 2025 · 6 comments · Fixed by #4547
Closed
4 tasks done

PitchSlider overlaps with Blocks when using Up and Down arrow keys #4466

Ubayed-Bin-Sufian opened this issue Feb 27, 2025 · 6 comments · Fixed by #4547

Comments

@Ubayed-Bin-Sufian
Copy link
Contributor

Description

When using the PitchSlider widget, pressing the Up and Down arrow keys causes the slider to overlap with blocks instead of moving independently.

Expected Behavior

When the PitchSlider widget is initialized, pressing the Up or Down arrow key should move only the slider, without overlapping with other elements.

Screenshots

Screenshare.-.2025-02-27.10_07_10.PM.mp4

How to Reproduce

  1. Switch to Advanced Mode.
  2. Initialize the PitchSlider widget.
  3. Press the Up and Down arrow keys.
  4. Observe that the slider overlaps with blocks instead of moving correctly.

Console log Errors

N/A

Additional Context

  • Investigated Activity.js:
    • this.palettes.activePalette should not be null in this.__keyPressed.
  • Need to check if this.blocksContainer.y is being modified unexpectedly.
  • Further debugging is required to identify potential conflicts.

Environment

  • Operating System: Windows (Need testing on macOS & Linux)
  • Browser: Chrome & Edge (Need testing on Firefox & Safari)
  • Version of Software/Project: [e.g., v3.6.2]

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@huamanraj
Copy link

@Ubayed-Bin-Sufian I'm interested in tackling this issue. Could you please assign it to me?

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@Ubayed-Bin-Sufian I'm interested in tackling this issue. Could you please assign it to me?

Please go ahead. No need to ask permission.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Ubayed-Bin-Sufian commented Mar 2, 2025

@walterbender Please have a look at this issue that I was referring to in the meet.

@walterbender
Copy link
Member

It is not clear how the arrow keys should behave when there are multiple sliders. Maybe we disable them?

@Ubayed-Bin-Sufian
Copy link
Contributor Author

It is not clear how the arrow keys should behave when there are multiple sliders. Maybe we disable them?

To my understanding, pitchslider block has one slider. Could you please let me know what do you mean by multiple sliders?

@walterbender
Copy link
Member

Try from advanced mode, which by default added two hertz blocks to the widget. You can add as many as you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants