Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Modernize Deprecated Music Processing Components #4502

Open
4 tasks done
lakshyeahh opened this issue Mar 6, 2025 · 2 comments · May be fixed by #4513
Open
4 tasks done

Cleanup and Modernize Deprecated Music Processing Components #4502

lakshyeahh opened this issue Mar 6, 2025 · 2 comments · May be fixed by #4513

Comments

@lakshyeahh
Copy link

Description
Several core music processing components are using deprecated properties and methods that need to be modernized or removed.

Areas Affected

  • Singer class (js/turtle-singer.js)
  • Note processing system
  • Rhythm blocks
  • Pitch blocks

Current Behavior

  1. Deprecated properties in Singer class:
    • attack[]
    • decay[]
    • sustain[]
    • release[]
  2. Deprecated RestBlock in PitchBlocks.js
  3. Deprecated NoteBlock in RhythmBlocks.js

Desired Situation

  1. Remove deprecated properties and replace with modern alternatives
  2. Consolidate note processing logic into a more maintainable structure
  3. Update block implementations to use current best practices

Technical Details

  • Files that need modification:
    • js/turtle-singer.js
    • js/blocks/PitchBlocks.js
    • js/blocks/RhythmBlocks.js

Benefits

  • Improved code maintainability
  • Reduced technical debt
  • Better performance through modern implementations

Difficulty: Medium
Priority: High
Labels: enhancement, technical-debt, music-system

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
@harith-hacky03
Copy link

@lakshyeahh Can I start working on this issue?

@Ashrafmuhmed
Copy link
Contributor

He mentioned that he will contribute to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants