Skip to content

Commit e162958

Browse files
committed
qgeotilefetchergooglemaps: small cleanup
Cleanup unused variables such as _versionGoogleMap and the related logic. QGeoTileFetcherGooglemaps::QGeoTileFetcherGooglemaps() - remove some commented out code QGeoTileFetcherGooglemaps::_googleVersionCompleted() - remove regex calls that update the version strings, yet said version strings are unused Signed-off-by: Lubomir I. Ivanov <[email protected]>
1 parent b679d0b commit e162958

File tree

2 files changed

+0
-43
lines changed

2 files changed

+0
-43
lines changed

qgeotilefetchergooglemaps.cpp

-37
Original file line numberDiff line numberDiff line change
@@ -50,32 +50,13 @@ QGeoTileFetcherGooglemaps::QGeoTileFetcherGooglemaps(const QVariantMap &paramete
5050
_userAgent = parameters.value(QStringLiteral("googlemaps.useragent")).toString().toLatin1();
5151
else
5252
_userAgent = "";
53-
// _userAgent = "Mozilla/5.0 (X11; Linux i586; rv:31.0) Gecko/20100101 Firefox/31.0";
54-
5553
QStringList langs = QLocale::system().uiLanguages();
5654
if (langs.length() > 0) {
5755
_language = langs[0];
5856
}
5957

6058
// Google version strings
61-
_versionGoogleMap = "m@338000000";
62-
_versionGoogleSatellite = "198";
63-
_versionGoogleLabels = "h@336";
64-
_versionGoogleTerrain = "t@132,r@338000000";
6559
_secGoogleWord = "Galileo";
66-
67-
// _tryCorrectGoogleVersions(m_networkManager);
68-
69-
// netRequest.setRawHeader("Referrer", "https://www.google.com/maps/preview");
70-
// netRequest.setRawHeader("Accept", "*/*");
71-
// netRequest.setRawHeader("User-Agent", _userAgent);
72-
73-
/* 2017: support new Google Maps Tile API (yet under development)
74-
You have to be whitelisted to use the Tile API. I can't tell how to get whitelisted.
75-
see https://developers.google.com/maps/documentation/tile/
76-
To use the new feature getUrl() and parsing the response has to be adapted. Maybe more than that...
77-
*/
78-
// _getSessionToken();
7960
}
8061

8162
QGeoTileFetcherGooglemaps::~QGeoTileFetcherGooglemaps()
@@ -195,24 +176,6 @@ void QGeoTileFetcherGooglemaps::_googleVersionCompleted()
195176
qDebug() << "Error collecting Google maps version info";
196177
return;
197178
}
198-
QString html = QString(_googleReply->readAll());
199-
200-
QRegExp reg("\"*https?://mt\\D?\\d..*/vt\\?lyrs=m@(\\d*)", Qt::CaseInsensitive);
201-
if (reg.indexIn(html) != -1) {
202-
QStringList gc = reg.capturedTexts();
203-
_versionGoogleMap = QString("m@%1").arg(gc[1]);
204-
}
205-
reg = QRegExp("\"*https?://khm\\D?\\d.googleapis.com/kh\\?v=(\\d*)", Qt::CaseInsensitive);
206-
if (reg.indexIn(html) != -1) {
207-
QStringList gc = reg.capturedTexts();
208-
_versionGoogleSatellite = gc[1];
209-
}
210-
reg = QRegExp("\"*https?://mt\\D?\\d..*/vt\\?lyrs=t@(\\d*),r@(\\d*)", Qt::CaseInsensitive);
211-
if (reg.indexIn(html) != -1) {
212-
QStringList gc = reg.capturedTexts();
213-
_versionGoogleTerrain = QString("t@%1,r@%2").arg(gc[1]).arg(gc[2]);
214-
}
215-
216179
_googleReply->deleteLater();
217180
_googleReply = NULL;
218181
}

qgeotilefetchergooglemaps.h

-6
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,13 @@ private slots:
4949
QString m_client;
5050
QString m_baseUri;
5151

52-
int _timeout;
5352
bool _googleVersionRetrieved;
5453
QNetworkReply* _googleReply;
5554
QMutex _googleVersionMutex;
5655
QByteArray _userAgent;
5756
QString _language;
58-
QJsonValue _sessionToken;
5957

6058
// Google version strings
61-
QString _versionGoogleMap;
62-
QString _versionGoogleSatellite;
63-
QString _versionGoogleLabels;
64-
QString _versionGoogleTerrain;
6559
QString _secGoogleWord;
6660

6761
QNetworkRequest netRequest;

0 commit comments

Comments
 (0)