Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section for FOUC bug in next js 13 #971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cyanhead
Copy link

@Cyanhead Cyanhead commented Jun 11, 2024

Changes

Adds a FAQ solving the flash of unstyled components bug in next js 13

Issue

Closes #927 and #922

image

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
styled-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 4:13pm

@Cyanhead
Copy link
Author

@quantizor please review

@Cyanhead
Copy link
Author

Hi @quantizor, a moment to review this?

```js
/** @type {import('next').NextConfig} */
const nextConfig = {
reactStrictMode: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strict mode required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's there because I copy-pasted the solution from #927. I can delete it if unnecessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let me know if I should take out strict mode

@quantizor
Copy link
Contributor

Maybe we could update the SSR section that already has next.js instructions? https://styled-components.com/docs/advanced#app-directory

@Cyanhead
Copy link
Author

Cyanhead commented Jun 23, 2024

I think it sits better in the FAQs, instead of the advanced section in https://styled-components.com/docs/advanced#app-directory, as both sets of information don't seem to be directly related.

However, having them in the same area is the best for easy access, and I can do that. Do I go ahead?

@Cyanhead
Copy link
Author

Cyanhead commented Jun 26, 2024

@quantizor I'll go ahead and put them in the same section.

@Cyanhead
Copy link
Author

Cyanhead commented Jul 4, 2024

Hi @quantizor, I've moved the changes to the SSR section. Review please
DEMO Video here

@Cyanhead
Copy link
Author

Hi again 👋🏽 @quantizor. Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a FAQ page added for this
2 participants