Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnRemove bug since 2.6.0 and later #249

Closed
steklopod opened this issue Feb 2, 2025 · 3 comments
Closed

OnRemove bug since 2.6.0 and later #249

steklopod opened this issue Feb 2, 2025 · 3 comments

Comments

@steklopod
Copy link

In 2.5.0 there is no such bug:

After changing pages in nuxt I get:

Image Image
@titouanmathis
Copy link
Collaborator

Hey @steklopod, thanks for the report. Can you share a link to a reproduction environment? Either a GitHub repository or a project on Codesandbox/Stackblitz will do.

steklopod added a commit to steklopod/vue-mapbox-gl that referenced this issue Feb 6, 2025
@steklopod
Fix MapboxMap unmount cleanup order
a69ad6c 
studiometa#249
@steklopod steklopod mentioned this issue Feb 6, 2025
Open
@steklopod
Copy link
Author

@titouanmathis I created the PR ti fix this

titouanmathis added a commit that referenced this issue Feb 12, 2025
@titouanmathis
Add issue #249 to the demo
49f6eb3
@titouanmathis titouanmathis mentioned this issue Feb 12, 2025
Merged
10 tasks
@titouanmathis
Copy link
Collaborator

Hey @steklopod, thanks for the PR!

While reviewing it, I was able to reproduce the bug locally and found a fix that should be more robust than the one you suggested (see #259).

Please try the next v2.7.2 release.

@titouanmathis titouanmathis mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titouanmathis @steklopod