Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ability to configure overlay background color for dark mode #114

Closed
emroot opened this issue Apr 29, 2024 · 6 comments
Closed

Comments

@emroot
Copy link

emroot commented Apr 29, 2024

There's no way to configure the background color for the overlay at the moment, it works great in light mode, but in a dark mode site, because the value is always the same, it looks a funky.

Light mode

image

Dark mode

image
@jojo-stripe
Copy link
Contributor

Do you mean a separate variable just for the background color of the overlay? That's different from the background color of the other components?

@emroot
Copy link
Author

emroot commented May 30, 2024

Yeah just the background color for the overlay, because in dark mode it looks washed out.
Works great on light mode tho

@emroot
Copy link
Author

emroot commented Sep 4, 2024

@jojo-stripe did my comment made sense? any sense if this is something you will be supporting?

@kaiying-stripe
Copy link
Contributor

@emroot we're planning to add a variable to enable customizing the background color in the near future.

@kaiying-stripe
Copy link
Contributor

@emroot We added the new variable overlayBackdropColor, closing this now. FFT reopen if there's other issues related to this!

@emroot
Copy link
Author

emroot commented Oct 16, 2024

Amazing!! Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants