Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Testing Module UI improvements #30773

Draft
wants to merge 8 commits into
base: next
Choose a base branch
from
Draft

Core: Testing Module UI improvements #30773

wants to merge 8 commits into from

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Mar 7, 2025 •
edited by storybook-pr-benchmarking bot
Loading

Closes #30746

What I did

  • Removed the "edit mode" toggle, instead options can be updated directly.
  • Added a "clear statuses" button which removes all statuses (dots in the sidebar).
  • Status dots are now clickable, to quickly find where the status originates.
  • Buttons are now slightly larger and the Run all button hides its label if necessary.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 79.9 MB 79.9 MB 0 B 0.32 0%
initSize 79.9 MB 79.9 MB 0 B 0.32 0%
diffSize 97 B 97 B 0 B - 0%
buildSize 7.47 MB 7.57 MB 97.1 kB 1.06 1.3%
buildSbAddonsSize 1.98 MB 1.98 MB 116 B 0.91 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.88 MB 1.89 MB 2.76 kB Infinity 0.1%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.06 MB 4.06 MB 2.88 kB 0.98 0.1%
buildPreviewSize 3.42 MB 3.51 MB 94.2 kB 0.92 2.7%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 11.5s 7.7s -3s -799ms -1.25 🔰-48.9%
generateTime 20.2s 21.5s 1.2s 1.46 🔺5.9%
initTime 4.9s 4.9s -35ms 0.55 -0.7%
buildTime 9.1s 9.2s 110ms -0.09 1.2%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.6s 4.8s 235ms -0.41 4.8%
devManagerResponsive 4.4s 4.6s 227ms -0.4 4.9%
devManagerHeaderVisible 782ms 761ms -21ms -0.4 -2.8%
devManagerIndexVisible 793ms 780ms -13ms -0.5 -1.7%
devStoryVisibleUncached 2.7s 2.4s -262ms -0.55 -10.6%
devStoryVisible 1.2s 1.1s -10ms -0.38 -0.8%
devAutodocsVisible 1.1s 1s -52ms -0.5 -4.9%
devMDXVisible 1.1s 1s -39ms -0.6 -3.6%
buildManagerHeaderVisible 880ms 841ms -39ms -0.21 -4.6%
buildManagerIndexVisible 885ms 859ms -26ms -0.19 -3%
buildStoryVisible 869ms 831ms -38ms -0.21 -4.6%
buildAutodocsVisible 618ms 745ms 127ms -0.38 17%
buildMDXVisible 666ms 692ms 26ms -0.64 3.8%

@ghengeveld ghengeveld self-assigned this Mar 7, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit aad7da7.

Command Status Duration Result
nx affected -t check -c production --parallel=7 ✅ Succeeded <1s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 4m 58s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-07 17:04:15 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Mar 7, 2025 •
edited
Loading

Package Benchmarks

Commit: aad7da7, ran on 7 March 2025 at 17:09:27 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-a11y

Before After Difference
Dependency count 3 51 🚨 +48 🚨
Self size 445 KB 445 KB 🚨 +43 B 🚨
Dependency size 2.81 MB 12.05 MB 🚨 +9.24 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-interactions

Before After Difference
Dependency count 5 51 🚨 +46 🚨
Self size 129 KB 129 KB 🚨 +62 B 🚨
Dependency size 3.11 MB 12.07 MB 🚨 +8.96 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-test

Before After Difference
Dependency count 9 55 🚨 +46 🚨
Self size 844 KB 844 KB 🎉 -412 B 🎉
Dependency size 4.56 MB 13.53 MB 🚨 +8.97 MB 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 98 51 🎉 -47 🎉
Self size 21.54 MB 19.65 MB 🎉 -1.90 MB 🎉
Dependency size 21.69 MB 14.26 MB 🎉 -7.43 MB 🎉
Bundle Size Analyzer Link Link

@storybook/experimental-nextjs-vite

Before After Difference
Dependency count 141 177 🚨 +36 🚨
Self size 215 KB 215 KB 🚨 +133 B 🚨
Dependency size 39.37 MB 48.71 MB 🚨 +9.34 MB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 540 581 🚨 +41 🚨
Self size 218 KB 454 KB 🚨 +236 KB 🚨
Dependency size 58.82 MB 82.96 MB 🚨 +24.14 MB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 122 124 🚨 +2 🚨
Self size 15 KB 15 KB 🚨 +127 B 🚨
Dependency size 20.46 MB 20.48 MB 🚨 +12 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 99 52 🎉 -47 🎉
Self size 1 KB 1 KB 0 B
Dependency size 43.24 MB 33.91 MB 🎉 -9.33 MB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 388 356 🎉 -32 🎉
Self size 282 KB 284 KB 🚨 +2 KB 🚨
Dependency size 93.24 MB 84.41 MB 🎉 -8.83 MB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 309 274 🎉 -35 🎉
Self size 614 KB 617 KB 🚨 +3 KB 🚨
Dependency size 74.84 MB 66.00 MB 🎉 -8.85 MB 🎉
Bundle Size Analyzer Link Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghengeveld ghengeveld

Labels
ci:normal feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking]: Test Polish 💅
1 participant
@ghengeveld