Support insecure-skip-verify while access a git server in subscription controller

[frankwg]

This is a customer requirement against MCM 1.3 and the channel controller has been added this feature.
In my fork of this repo, I fixed the issue through this commit frankwg@3a88e87.

Is it possible to create a branch name 'ibm-3.3.0' from the commit 2602450, so, I can raise a PR to merge my change to it?

[ianzhang366]

Hi @frankwg

I've created the branch for you when you create PR can you please double-check with the following fix, to make sure we reuse as much as code.

https://github.com/open-cluster-management/multicloud-operators-channel/pull/55/files

[frankwg]

Hi @ianzhang366

Actually, I did, but not applicable. We uses go-git to clone git repos. Hence, we need to follow its way of turning on insecure-skip-verify flag as https://git-scm.com/book/fa/v2/Appendix-B%3A-Embedding-Git-in-your-Applications-go-git

[frankwg]

Hi @ianzhang366

Do you have any concern about the code? Due to we're in MCM 2.0 SVT, it's better to have this code test before GA.

Here is the PR
#241

BTW, I don't know why Sonar and Travis check didn't proceed. Do I miss something?

[ianzhang366]

Hi @frankwg it seems your code is based on an out of date master branch... can you please rebase it to the most recent master branch?