Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shellcheck tests optional for local development #351

Open
Gyan-max opened this issue Mar 12, 2025 · 0 comments
Open

Make shellcheck tests optional for local development #351

Gyan-max opened this issue Mar 12, 2025 · 0 comments

Comments

@Gyan-max
Copy link

Gyan-max commented Mar 12, 2025

Currently, contributors need to have shellcheck installed locally in order to run all tests with cargo test -p wdl-lint --all-features. This creates an extra dependency that not all contributors may have readily available on their systems, especially on Windows where shellcheck installation is less common.
When shellcheck is not installed, tests fail with errors that are not related to the changes being made, which can be confusing and act as a barrier to contribution.

Benefits

  • Lower barrier to entry for new contributors
  • Faster test runs for developers not working on shellcheck-related functionality
  • Clearer test failures related to actual code changes
  • CI still ensures all tests pass in the complete environment
  • This change would improve developer experience while maintaining code quality standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant