Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker backend: implement a chown workaround after task execution #329

Open
peterhuene opened this issue Feb 26, 2025 · 3 comments
Open
Labels
good first issue Good for newcomers

Comments

@peterhuene
Copy link
Collaborator

Currently files created by a container in the Docker backend will be created as root on systems where the docker daemon is running as root.

This leaves files in the output directory that cannot be removed by the user unless they elevate their privileges.

miniwdl solves this with a workaround where a special container is executed to chown the working directory contents to the user; as the container is also run as root, it doesn't require the user executing miniwdl to elevate their privileges.

We should consider implementing a similar workaround.

@stjude-rust-labs stjude-rust-labs deleted a comment from bhartiRaz Mar 1, 2025
@claymcleod claymcleod added the good first issue Good for newcomers label Mar 1, 2025
@thedeeppp
Copy link

Hey, I would like to work on this issue. might need a little help.

@ashug06
Copy link

ashug06 commented Mar 4, 2025

Hi! I’m Ashutosh Goyal, and I’m interested in contributing to this project. I’d love to take up this issue. Could you please assign it to me?

@blenbot
Copy link

blenbot commented Mar 5, 2025

Hello! I tried to analyze the codebase and got hold off it mostly as well as miniwdl's workaround and came up with a solution to include post execution cleanup container mounting the folders in the container after each run of main containers and lastly change the ownership in the cleanup, let me know what you think, I have already started working on this and I would be really glad if you could assign me this issue. I was thinking of making minimal changes to crankshaftbackend class, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants