Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LambdaHackWeek: Fix Error: You Must Provide a signTransaction Function #159

Closed
Julian-dev28 opened this issue Jul 2, 2024 · 2 comments
Closed
Labels
good first issue Good for newcomers

Comments

@Julian-dev28
Copy link
Contributor

Julian-dev28 commented Jul 2, 2024

Please add PRs to the update-P21 branch

Description:
Resolve the error occurring in the form-pledge component, where a signTransaction function must be provided either when calling signAndSend or when initializing the Client.

Source:
components/molecules/form-pledge/index.tsx (Line 51:18) @ signAndSend

Tasks:

  1. Review Current Implementation:

    • Review the current implementation of the form-pledge component.
    • Identify where the signTransaction function should be integrated.
  2. Provide signTransaction Function:

    • Implement the signTransaction function.
    • Ensure the function is either passed when calling signAndSend or during Client initialization.
  3. Update signAndSend Call:

    • Update the call to signAndSend to include the signTransaction function.
    • Ensure proper handling and passing of required parameters.
  4. Test Functionality:

    • Recreate the issue by running yarn reset, yarn dev, and then clicking the "Mint 100 ABND" button.
    • Test the updated implementation to ensure the error is resolved.
    • Verify that the transaction signing and sending process works as expected.
  5. Update Documentation:

    • Document the changes made to the form-pledge component.
    • Provide instructions on how to use the updated signAndSend functionality.

Expected Outcome:

  • The error regarding the missing signTransaction function is resolved.
  • The form-pledge component correctly signs and sends transactions without errors.
  • Updated documentation reflecting the changes and providing usage instructions.

Why This Is Important:
Fixing this error is crucial for ensuring that transactions can be signed and sent correctly within the Soroban Example Dapp. This will enhance the functionality and reliability of the Dapp, providing a smoother user experience.

Code Reference:

components/molecules/form-pledge/index.tsx (Line 51:18) @ signAndSend

  49 | setSubmitting(true)
  50 | const tx = await abundance.mint({ to: account, amount: amount })
> 51 | await tx.signAndSend()
     |        ^
  52 | setSubmitting(false)
  53 | onComplete()
  54 | }}
@Julian-dev28 Julian-dev28 changed the title LambdaHackWeek: Fix Error: You Must Provide a signTransaction Function LambdaHackWeek: Fix Error: You Must Provide a signTransaction Function Jul 2, 2024
@kamalbuilds
Copy link

Hello , I am looking forward to fix this for the LamdaHackWeek.

@Julian-dev28
Copy link
Contributor Author

fixed by #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants