Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add schema and validation for syntax highlighting themes in the REPL #2340

Open
3 tasks done
Snehil-Shah opened this issue Jun 8, 2024 · 2 comments
Open
3 tasks done

[RFC]: add schema and validation for syntax highlighting themes in the REPL #2340

Snehil-Shah opened this issue Jun 8, 2024 · 2 comments
Assignees
@Snehil-Shah
Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. REPL Issue or pull request specific to the project REPL. status: Blocked Issue or pull request which is current blocked.

Comments

@Snehil-Shah
Copy link
Member

Description

This RFC proposes adding JSON schema and validation for when a user is providing their own set of themes. Currently, the user can provide any object as a theme without them knowing what's wrong.

Related Issues

Follow up to #2291

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. REPL Issue or pull request specific to the project REPL. Accepted RFC feature request which has been accepted. labels Jun 8, 2024
@kgryte
Copy link
Member

kgryte commented Jun 8, 2024

One thing that we'd need to consider is whether to make ajv a production dependency, or whether we should roll our own JSON schema validator. The implementation of ajv does not appear trivial: https://github.com/ajv-validator/ajv/tree/master. In order to be a production dependency, we'd need to ensure it works across our supported environments.

@kgryte kgryte added the status: Blocked Issue or pull request which is current blocked. label Jun 8, 2024
@kgryte
Copy link
Member

kgryte commented Jun 8, 2024

I'll go ahead and mark this as "blocked" until we figure out the path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Snehil-Shah Snehil-Shah

Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. REPL Issue or pull request specific to the project REPL. status: Blocked Issue or pull request which is current blocked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgryte @Snehil-Shah