Faling connection to dapp (CoinMarketCap)

[clauxx]

Bug Report

Problem

When attempting to connect to https://coinmarketcap.com pairing succeeds, but it fails on the next step during authentication via personal_sign. Also the message is not visible to the user on the signing modal.

It seems like the issue is that most dapps send the personal_sign data as hex already, while here they send it as UTF-8. We should check if the data is sent as hex before hashing it, and if it's not - hex it ourselves. The same with displaying it - only decode it to UTF-8 if it is hex encoded.

Expected behavior

Can see the authentication message (message signing) and connect to CoinMarketCap successfully.

Actual behavior

Can't see the message nor connect to CoinMarketCap

Reproduction

1. Go to https://coinmarketcap.com
2. Press Connect
3. Open Status app and log in
4. Scan the QR code
5. Approve pairing
6. The dapp should react and prompt a captcha puzzle
7. When done, it should send a personal_sign request
8. The request message will be empty (!)
9. After approving signing via password/biometrics/keycard, it should show an error (!)

Additional Information

• Status version: nightly
• Operating System: Android, iOS

[shivekkhurana]

Did you check if this issue exists on Rainbow or Coinbase wallet too ?

[mohsen-ghafouri]

@shivekkhurana I just tested with Status Desktop version and it works fine, it successfully paired with CoinMarketCap. JFYI