feat: soft-delete player instead of removing them

Author: aashutoshrathi

src/index.ts

@@ -140,7 +140,9 @@ const main = async () => {
       return acc;
     }, {} as Record<string, PlayerStats>);
 
-    const playerWithDetails = players.map((p) => getPlayerInfo(p.id));
+    const playerWithDetails = players
+      .filter((p) => !p.removedAt)
+      .map((p) => getPlayerInfo(p.id));
 
     const sortedPlayersWithDetails = playerWithDetails
       .map((playerInfo) => {
@@ -319,7 +321,7 @@ const main = async () => {
    */
   app.get("/players", (_req: Request, res: Response) => {
     const { players } = machine.state;
-    return res.send(players);
+    return res.send(players.filter((p) => !p.removedAt));
   });
 
   /**

src/stackr/state.ts

@@ -31,6 +31,7 @@ export type Player = {
   id: number;
   name: string;
   teamId: number;
+  removedAt?: number;
 };
 
 export type Logs = {
@@ -68,7 +69,10 @@ export class League extends State<LeagueState> {
     );
 
     const playersMerkleTree = createMT(players, (p) =>
-      solidityPacked(["uint256", "string", "uint256"], [p.id, p.name, p.teamId])
+      solidityPacked(
+        ["uint256", "string", "uint256", "uint256"],
+        [p.id, p.name, p.teamId, p.removedAt || 0]
+      )
     );
 
     const matchesMMR = createMMR(matches, (m) => {

src/stackr/transitions.ts

@@ -468,7 +468,7 @@ const addPlayer: STF<League, { teamId: number; playerName: string }> = {
 };
 
 const removePlayer: STF<League, { teamId: number; playerId: number }> = {
-  handler: ({ state, inputs }) => {
+  handler: ({ state, inputs, block }) => {
     const { teamId, playerId } = inputs;
     const player = state.players.find((p) => p.id === playerId);
     if (!player) {
@@ -479,7 +479,7 @@ const removePlayer: STF<League, { teamId: number; playerId: number }> = {
       throw new Error("INVALID_TEAM");
     }
 
-    state.players = state.players.filter((p) => p.id !== playerId);
+    player.removedAt = block.timestamp;
     return state;
   },
 };