chore: remove goal from a player only if they have scored it (#24)

Author: aashutoshrathi

deployment.json

@@ -2,4 +2,4 @@
   "appId": 8,
   "appInbox": "0xa2a5d72B29C9Ccdc2c6594Bf9eD92cBd5A3bAf58",
   "chainId": 69420
-}
+}

src/stackr/transitions.ts

@@ -326,6 +326,17 @@ const removeGoal: STF<League, GoalRequest> = {
     if (match.scores[teamId] === 0) {
       throw new Error("NO_GOALS_TO_REMOVE");
     }
+    const correspondingGoalIdx = state.logs.findIndex(
+      (l) =>
+        l.matchId === matchId &&
+        l.playerId === playerId &&
+        l.action === LogAction.GOAL
+    );
+
+    if (correspondingGoalIdx === -1) {
+      throw new Error("NO_GOALS_TO_REMOVE");
+    }
+
     match.scores[teamId] -= 1;
     state.logs.push({
       playerId,