Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If sats received, do not show invoice as expired #1363

Open
SouthKoreaLN opened this issue Sep 5, 2024 · 3 comments
Open

If sats received, do not show invoice as expired #1363

SouthKoreaLN opened this issue Sep 5, 2024 · 3 comments

Comments

@SouthKoreaLN
Copy link
Contributor

SouthKoreaLN commented Sep 5, 2024

Is your feature request related to a problem? Please describe.

I think this was not an issue before with the custodial SN wallet as the invoice would mostly always get paid right away. Here, now that i use NWC, I did not notice that the post I submitted 19 minutes ago hadn't been paid yet. However, the invoice expired, so as far as I know, I have to create a new post.

Describe the solution you'd like
It would be nice to just be able to request a new invoice.

Describe alternatives you've considered
I can just make a new post of course, so it is not critical.

Additional context
See the pending mention in both these screenshots.

Screenshot 2024-09-05 at 9 27 57 AM

and

Screenshot 2024-09-05 at 9 24 13 AM
@SouthKoreaLN SouthKoreaLN added the feature new product features that weren't there before label Sep 5, 2024
@SouthKoreaLN
Copy link
Contributor Author

Oh, my bad, turns out I just had to wait a few more minutes and then the usual Retry button appeared. So what I describe is just the edge case in between the moment the first invoice expires and the moment the Retry button appears... so I guess a quick fix would be to have the invoice expiration time match the moment the retry button appears...

@huumn
Copy link
Member

huumn commented Sep 5, 2024

hmmm that's a bug. If it expired, it shouldn't be pending.

@huumn huumn changed the title Add ability to request a new invoice when the previous one expired Expired invoices can show as pending after expiration Sep 5, 2024
@huumn huumn added bug wallets and removed feature new product features that weren't there before labels Sep 5, 2024
@huumn
Copy link
Member

huumn commented Sep 24, 2024

On second thought, I suspect the item was retried (with another invoice) and was in fact pending but the invoice being viewed had expired.

This is a UX issue.

The above is wrong. It sounds more like the invoice was paid before expiration but we failed to update the state from pending -> paid and erroneously show it as expired. We should probably have the actionState override the invoice state.

@huumn huumn added the ux label Sep 24, 2024
@huumn huumn changed the title Expired invoices can show as pending after expiration If sats received, do not show invoice as expired Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants