Where reasonable, convert tests to free functions

[gadomski]

We switched to pytest in #939, which means we don't have to use unittest.TestCase anymore; we can switch to free functions. In most cases, converting tests should be as simple as changing:

class MyTestCase(unittest.TestCase):
    def test_foo(self) -> None:
        self.assertTrue(True)

to

def test_foo() -> None:
    assert True

While this is a little bike-sheddy, this does have some benefits:

• Enable fixtures, parameterization, and custom hooks
• Reduces confusion for new contributors, who might be unsure of which test format to use
• Reduces the indentation level (a little thing, I know, but IMO it reads cleaner to have less leading whitespace)

[teks]

This seems straightforward so I'll make an attempt. 28 files have import unittest so I may split it into a few PRs so they don't get too long.

However, please let me know if there's a body of tests I should leave alone until some other work is done.

[gadomski]

Nope, go to town 😄

[teks]

Here are the sed invocations I'm using to replace the unittest asserts in case someone else ends up working on this:

sed -i '' -E 's/self.assertEqual\((.*), (.*)\)/assert \1 == \2/' $FILENAME
sed -i '' -E 's/self.assertNotEqual\((.*), (.*)\)/assert \1 != \2/' $FILENAME
sed -i '' -E 's/self.assertDictEqual\((.*), (.*)\)/assert \1 == \2/' $FILENAME
sed -i '' -E 's/self.assertListEqual\((.*), (.*)\)/assert \1 == \2/' $FILENAME
sed -i '' -E 's/self.assertTrue\((.*)\)/assert \1/' $FILENAME
sed -i '' -E 's/self.assertFalse\((.*)\)/assert not \1/' $FILENAME
sed -i '' -E 's/self.assertIs\((.*), (.*)\)/assert \1 is \2/' $FILENAME
sed -i '' -E 's/self.assertIsNot\((.*), (.*)\)/assert \1 is not \2/' $FILENAME
sed -i '' -E 's/self.assertIsNone\((.*)\)/assert \1 is None/' $FILENAME
sed -i '' -E 's/self.assertIsInstance\((.*), (.*)\)/assert isinstance(\1, \2)/' $FILENAME
sed -i '' -E 's/self.assertIn\((.*), (.*)\)/assert \1 in \2/' $FILENAME
sed -i '' -E 's/self.assertNotIn\((.*), (.*)\)/assert \1 not in \2/' $FILENAME

Note this is macos sed, and regexes an imperfect subsitute for a real parser, so one still needs to visually inspect the results.