Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popcorn should not use ksys_{brk,mremap,madvise,mprotect} #96

Open
bxatnarf opened this issue Dec 18, 2019 · 0 comments
Open

popcorn should not use ksys_{brk,mremap,madvise,mprotect} #96

bxatnarf opened this issue Dec 18, 2019 · 0 comments
Labels
style any type of linux style compliance issue upstream

Comments

@bxatnarf
Copy link
Collaborator

ksys_brk, ksys_mremap, ksys_madvise, and ksys_mprotect are not supposed to be globally accessible but are because popcorn uses them.
For example:

popcorn-kernel/kernel/popcorn/vma_server.c

Line 502 in e44428e

req->brk = ksys_brk(req->brk);

@bxatnarf bxatnarf added upstream style any type of linux style compliance issue labels Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
style any type of linux style compliance issue upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bxatnarf