I have just fixed an error in the setMerchantCofIni method. It always returns the value 'S'

Author: ssheduardo

CHANGELOG.md

@@ -2,6 +2,17 @@
 
 All Notable changes to `Redsys` will be documented in this file
 
+## Version 1.4.9 (2025-01-11)
+### Added
+- None
+
+### Changed
+- None
+
+### Fixed
+- I have just fixed an error in the setMerchantCofIni method. It always returns the value 'S'.
+
+
 ## Version 1.4.8 (2024-03-05)
 ### Added
 - Implementation of the `xpay` method within the `setMethod` functionality to support GooglePay and ApplePay.

src/Sermepa/Tpv/Tpv.php

@@ -943,12 +943,19 @@ public function getMerchantSignature()
      * “S”: It is first COF transaction (store credentials)
      * “N”: It is not the first COF transaction
      *
+     * @param $value
+     *
      * @return $this
      * @throws Exception
      */
-    public function setMerchantCofIni($isFirstTransaction)
+    public function setMerchantCofIni($value)
     {
-        $this->_setParameters['DS_MERCHANT_COF_INI'] = $isFirstTransaction ? 'S' : 'N';
+        $validOptions = ['S', 'N'];
+        $value = strtoupper($value);
+        if (!in_array($value, $validOptions, true)) {
+            throw new TpvException('Set Merchant COF INI valid options');
+        }
+        $this->_setParameters['DS_MERCHANT_COF_INI'] = $value;
 
         return $this;
     }

tests/TpvTest.php

@@ -630,4 +630,50 @@ public function throw_when_set_environment_or_version_is_invalid($environment, $
         $redsys = new Tpv();
         $redsys->getJsPath($environment, $version);
     }
+
+    public function cofIniProvider()
+    {
+        return [
+            ['S'],
+            ['N'],
+        ];
+    }
+
+    /**
+     *
+     * @dataProvider cofIniProvider
+     */
+    public function test_should_validate_a_merchant_cof_ini($cofIni)
+    {
+        $redsys = new Tpv();
+        $redsys->setMerchantCofIni($cofIni);
+        $parameters = $redsys->getParameters();
+        $this->assertArrayHasKey('DS_MERCHANT_COF_INI', $parameters);
+        $this->assertContains($parameters['DS_MERCHANT_COF_INI'], [$cofIni]);
+
+    }
+
+    public function invalidSetMerchantCofIni()
+    {
+        return [
+            [''],
+            ['B'],
+            ['-1'],
+            ['G'],
+            [0],
+            ['Del']
+        ];
+    }
+
+    /**
+     * @test
+     * @dataProvider invalidSetMerchantCofIni
+     */
+    public function throw_when_set_method_merchnant_cof_ini_is_invalid($cofIni)
+    {
+        $this->expectExceptionMessage("Set Merchant COF INI valid options");
+        $this->expectException(\Sermepa\Tpv\TpvException::class);
+        $redsys = new Tpv();
+        $redsys->setMerchantCofIni($cofIni);
+    }
 }