Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider emitting JS splice operator to optimize varargs functions #31

Open
borkdude opened this issue Jul 30, 2022 · 4 comments
Open

Consider emitting JS splice operator to optimize varargs functions #31

borkdude opened this issue Jul 30, 2022 · 4 comments
Labels
low priority

Comments

@borkdude
Copy link
Member

Questions: is splice supported everywhere now? What do we gain, what risk do we take by optimizing this?
@mk
Copy link
Contributor

mk commented Jul 31, 2022

is splice supported everywhere now?

No IE 11, but everything else seems to be ok (including Edge which afaik is the default browser on windows now): https://caniuse.com/mdn-javascript_operators_spread

@borkdude
Copy link
Member Author

Cool!

@mk
Copy link
Contributor

mk commented Jul 31, 2022

A small amendment: IE 11 also only has partial support for es6 https://caniuse.com/es6 (which the splice operator is part of), for example no support for es6 class https://caniuse.com/es6-class so it really seems like there’s no compatibility downside to adopting it.

@borkdude
Copy link
Member Author

Yeah, IE is dead now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mk @borkdude