Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending actions during action propagation should likely assert #275

Open
jamieQ opened this issue Mar 11, 2024 · 0 comments
Open

sending actions during action propagation should likely assert #275

jamieQ opened this issue Mar 11, 2024 · 0 comments

Comments

@jamieQ
Copy link
Contributor

jamieQ commented Mar 11, 2024

consider the following pattern:

childWorkflow
  .mapOutput { sink.send(.someOutput) }
  .ignoreOutput()
  .rendered(in: context)

this will often 'work', but causes concurrent action handling in the runtime. using sinks during action propagation should likely trigger some form of debug assertion at a minimum, since emitting actions during action handling can lead to unexpected processing/dropped events, or redundant render passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant