Add GraphQLContextHolder like SecurityContextHolder?

[Sam-Kruglov]

It appears there's no way to access GraphQLContext other than inject it into a resolver method argument like so:

@QueryMaping
fun myQuery(context: GraphQLContext)...

And then we must pass it around in all the downstream methods so that they can access it. Spring Security has the same problem of accessing the current user information from JWT and they have SecurityContextHolder (https://docs.spring.io/spring-security/reference/servlet/authentication/architecture.html#servlet-authentication-securitycontextholder) which simply stores all the context in a ThreadLocal. And they have something else for reactive context too.

Why don't we do the same for graphql context? I feel like it's inconvenient to pass it around, it should be doable to just store it in a thread local?

Or perhaps we could add the whole DataFetchingEnvironment in a thread local?

[rstoyanchev]

It is not possible to answer your question without knowing more details about where the data you want to propagate originates from.

In the case of SecurityContextHolder, it is set in a Filter or WebFilter and is propagated from there. In Spring for GraphQL we already propagate context from the web layer (like Security context), through the GraphQL engine, and down to individual controller method invocation, and it is available in any methods you call too. We do that through the context-propagation library, and this is also explained in the section on context propagation in the Spring for GraphQL docs.

This is the same mechanism that you can use, but it depends what data you need to propagate and where it is set from.