Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch remaining jUnit 4 tests to jUnit jupiter #4011

Open
OlgaMaciaszek opened this issue Jul 7, 2021 · 18 comments · May be fixed by #4425
Open

Switch remaining jUnit 4 tests to jUnit jupiter #4011

OlgaMaciaszek opened this issue Jul 7, 2021 · 18 comments · May be fixed by #4425

Comments

@OlgaMaciaszek
Copy link
Collaborator

No description provided.

@SivaTharun
Copy link

@OlgaMaciaszek can i work on this issue.

@OlgaMaciaszek
Copy link
Collaborator Author

@SivaTharun , thanks for reaching out. @maniotie is already working on this issue for now. If not all modules are converted, I will get back to you here.

@OlgaMaciaszek
Copy link
Collaborator Author

@maniotie is now working on reducing method and class visibility after the conversion to JUnitJupiter.

@ThomasTopuz
Copy link

Is anybody working on this?

@OlgaMaciaszek
Copy link
Collaborator Author

I don't think anybody is at the moment. They are only a few test left, but possibly the ones that were proving tricky during the previous work done by contributors. Would you like to work on it @ThomasTopuz ?

@deii
Copy link

deii commented Jun 11, 2024

The remaining tests use the deprecated ModifiedClassPathRunner class. It would be possible to replace it with ModifiedClassPathExtension, but this class has a package-access level. How could we solve this? Should I create an issue and patch in the spring-cloud-commons project?

https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-test-support/src/main/java/org/springframework/cloud/test/ModifiedClassPathExtension.java#L49

@OlgaMaciaszek
Copy link
Collaborator Author

Right, @deii. Have created: spring-cloud/spring-cloud-commons#1358.

@OlgaMaciaszek
Copy link
Collaborator Author

It's merged now. @deii @ThomasTopuz Let me know if any of you would like to work on this.

@Pjaygit
Copy link

Pjaygit commented Nov 12, 2024

@OlgaMaciaszek is this available to work?

@OlgaMaciaszek
Copy link
Collaborator Author

Yes, @Pjaygit. Would you like to work on it?

@Pjaygit
Copy link

Pjaygit commented Nov 12, 2024

Sure. Would like to try @OlgaMaciaszek

@OlgaMaciaszek
Copy link
Collaborator Author

Sounds good, @Pjaygit. Please go ahead.

@OlgaMaciaszek
Copy link
Collaborator Author

Please add your changes against the 4.1.x branch.

@spencergibb spencergibb moved this to Todo in 2023.0.4 Dec 2, 2024
@spencergibb spencergibb moved this to Todo in 2025.0.0-M1 Dec 2, 2024
@spencergibb spencergibb removed this from 2023.0.5 Jan 10, 2025
@spencergibb spencergibb moved this to Todo in 2024.0.1 Jan 10, 2025
@spencergibb spencergibb moved this to Todo in 2023.0.6 Jan 10, 2025
david-vana added a commit to david-vana/spring-cloud-netflix that referenced this issue Mar 8, 2025
david-vana added a commit to david-vana/spring-cloud-netflix that referenced this issue Mar 8, 2025
@david-vana
Copy link

david-vana commented Mar 8, 2025

Looks like nobody is working on this currently. Could you please check my PR #4421 @OlgaMaciaszek ?

@OlgaMaciaszek
Copy link
Collaborator Author

Thanks, @david-vana - will review this week.

@david-vana
Copy link

@OlgaMaciaszek My PR is agains 4.2.x but as I realized - it should be earliest maintained branch 4.1.x, right? Should I create new PR agains 4.1.x?

@OlgaMaciaszek
Copy link
Collaborator Author

@david-vana Yes, please.

@OlgaMaciaszek OlgaMaciaszek assigned david-vana and unassigned Pjaygit Mar 13, 2025
@OlgaMaciaszek OlgaMaciaszek moved this to In Progress in 2025.0.0-M3 Mar 13, 2025
@OlgaMaciaszek OlgaMaciaszek moved this from Todo to In Progress in 2023.0.6 Mar 13, 2025
@OlgaMaciaszek OlgaMaciaszek moved this from Todo to In Progress in 2024.0.1 Mar 13, 2025
@OlgaMaciaszek OlgaMaciaszek added this to the 4.1.6 milestone Mar 13, 2025
@spencergibb spencergibb removed this from 2024.0.1 Mar 19, 2025
@spencergibb spencergibb moved this to In Progress in 2024.0.2 Mar 19, 2025
david-vana added a commit to david-vana/spring-cloud-netflix that referenced this issue Mar 21, 2025
david-vana added a commit to david-vana/spring-cloud-netflix that referenced this issue Mar 21, 2025
david-vana added a commit to david-vana/spring-cloud-netflix that referenced this issue Mar 21, 2025
@david-vana
Copy link

New PR #4425 against 4.1.x ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: In Progress
Status: In Progress
Development

Successfully merging a pull request may close this issue.

7 participants