-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch remaining jUnit 4 tests to jUnit jupiter #4011
Comments
@OlgaMaciaszek can i work on this issue. |
@SivaTharun , thanks for reaching out. @maniotie is already working on this issue for now. If not all modules are converted, I will get back to you here. |
@maniotie is now working on reducing method and class visibility after the conversion to JUnitJupiter. |
Is anybody working on this? |
I don't think anybody is at the moment. They are only a few test left, but possibly the ones that were proving tricky during the previous work done by contributors. Would you like to work on it @ThomasTopuz ? |
The remaining tests use the deprecated |
Right, @deii. Have created: spring-cloud/spring-cloud-commons#1358. |
It's merged now. @deii @ThomasTopuz Let me know if any of you would like to work on this. |
@OlgaMaciaszek is this available to work? |
Yes, @Pjaygit. Would you like to work on it? |
Sure. Would like to try @OlgaMaciaszek |
Sounds good, @Pjaygit. Please go ahead. |
Please add your changes against the |
Signed-off-by: David Vana <[email protected]>
Signed-off-by: David Vana <[email protected]>
Looks like nobody is working on this currently. Could you please check my PR #4421 @OlgaMaciaszek ? |
Thanks, @david-vana - will review this week. |
@OlgaMaciaszek My PR is agains 4.2.x but as I realized - it should be earliest maintained branch 4.1.x, right? Should I create new PR agains 4.1.x? |
@david-vana Yes, please. |
Signed-off-by: David Vana <[email protected]>
Signed-off-by: David Vana <[email protected]>
Signed-off-by: David Vana <[email protected]>
New PR #4425 against 4.1.x ready for review. |
No description provided.
The text was updated successfully, but these errors were encountered: