Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header names should not be case sensitive #1230

Closed
deki opened this issue Feb 4, 2025 · 0 comments
Closed

Header names should not be case sensitive #1230

deki opened this issue Feb 4, 2025 · 0 comments
Assignees
Milestone

Comments

@deki
Copy link
Contributor

deki commented Feb 4, 2025

ServerlessHttpServletRequest currently stores and retrieves headers in a case sensitive way. Header names should not not be treated case sensitive though.
From RFC 2616 - "Hypertext Transfer Protocol -- HTTP/1.1", Section 4.2, "Message Headers":

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

The updating RFC 7230 does not list any changes from RFC 2616 at this part.

Examples: request.getHeader("User-Agent") works, request.getHeader("user-agent") returns no result and vice versa.

Tomcat converts all headers to lower case directly but in my view making lookup case insensitive would already fix it.

@olegz olegz added this to the 4.3 milestone Mar 25, 2025
olegz added a commit that referenced this issue Apr 2, 2025
@olegz olegz closed this as completed in 6a90ba2 Apr 2, 2025
@olegz olegz self-assigned this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants