Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Please doesn't run git hooks when making the release PR #35

Open
Billlynch opened this issue Oct 26, 2023 · 2 comments
Open

Release Please doesn't run git hooks when making the release PR #35

Billlynch opened this issue Oct 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Billlynch
Copy link
Collaborator

Expected Behavior

Release please should run the git hooks when making the release PR, to update the examples' deps.

Current Behavior

the hook is not run, so we have to manually run the update script.
@Billlynch Billlynch added the bug Something isn't working label Oct 26, 2023
@Billlynch Billlynch mentioned this issue Oct 26, 2023
Merged
@Billlynch
Copy link
Collaborator Author

Also Release Please doesn't ripple updates.

If you update client-http
It will not bump the versions in confidence-provider-web

@beeme1mr
Copy link

Also Release Please doesn't ripple updates.

If you update client-http It will not bump the versions in confidence-provider-web

Hey @Billlynch, you may want to try the node-workspace plugin for Release Please.

You can see an example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beeme1mr @Billlynch