-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note bars are drawn to different positions w.r.t. generated midi #147
Comments
Hello! I am planning on looking into this issue and update you if I have any further clarification questions or successes. |
I can confirm that the MIDI file contains the right notes, and the html canvas notes are wrong (they are 1 semitone higher than expected). |
Is this something that can be fixed in the provided source code in the GitHub? |
Unfortunately, the code for rendering the UI is internal to Spotify and can only be changed by someone at Spotify. https://github.com/spotify/basic-pitch-ts only covers the inference in typescript. All typescript/web related issues should be posted there. |
So opening this issue at basic-pitch-ts repo will not help either? 🤔 |
Describe the bug
After transcription, note bars are drawn to an html canvas for visualization. When midi file is exported and opened at another software, notes are drawn at different positions. At Basic Pitch, note bars are drawn to ~1.2 higher note positions w.r.t. generated midi.
To Reproduce
Expected behavior
Note bars' positions are the same both at Basic Pitch and at another software.
Screenshots
Basic Pitch:
Online Sequencer:
Desktop:
Additional context
To my rookie ears, note bars drawn at Basic Pitch are not the correct ones.
The text was updated successfully, but these errors were encountered: