SYN-5006: Expose status code for api errors (#31)

Author: Pajk

syntheticsclientv2/synthetics.go

@@ -96,6 +96,9 @@ func (c Client) makePublicAPICall(method string, endpoint string, requestBody io
 		return &details, err
 	}
 
+	details.StatusCode = resp.StatusCode
+	details.RawResponse = resp
+
 	if resp.StatusCode < http.StatusOK || resp.StatusCode >= http.StatusBadRequest {
 		var errRes errorResponse
 		if err = json.NewDecoder(resp.Body).Decode(&errRes); err == nil {
@@ -113,9 +116,7 @@ func (c Client) makePublicAPICall(method string, endpoint string, requestBody io
 		return &details, err
 	}
 
-	details.StatusCode = resp.StatusCode
 	details.ResponseBody = string(responseBody)
-	details.RawResponse = resp
 
 	return &details, nil
 }

syntheticsclientv2/synthetics_test.go

@@ -98,3 +98,26 @@ func TestConfigurableClientTimeout(t *testing.T) {
 		t.Errorf("expected to see timeout error, but saw: %s", err.Error())
 	}
 }
+
+func TestConfigurableClientErrorStatusCode(t *testing.T) {
+	testMux = http.NewServeMux()
+	testServer = httptest.NewServer(testMux)
+
+	testMux.HandleFunc("/tests", func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusNotFound)
+		w.Write([]byte(`{"status":"404"}`))
+	})
+
+	testConfigurableClient := NewConfigurableClient("apiKey", "realm", ClientArgs{
+		publicBaseUrl: testServer.URL,
+	})
+	details, err := testConfigurableClient.makePublicAPICall("GET", "/tests", nil, nil)
+
+	if !strings.Contains(err.Error(), "404 Not Found") {
+		t.Errorf("expected to see 404 error, but saw: %s", err.Error())
+	}
+
+	if details.StatusCode != http.StatusNotFound {
+		t.Errorf("expected to see 404 status code, but saw: %d", details.StatusCode)
+	}
+}