Skip to content

Commit ce64f54

Browse files
authoredDec 15, 2016
Updated for cocoaPods 1.x + (#64)
- Updated podfile - Updated cocoapods to 1.1.1 - Updated circle.yml — use latest ios SDK; updated device ID for instruments
1 parent 9ef0465 commit ce64f54

File tree

10 files changed

+145
-59
lines changed

10 files changed

+145
-59
lines changed
 

‎Example/ExampleSSDataSources.xcodeproj/project.pbxproj

+85-24
Large diffs are not rendered by default.

‎Example/ExampleSSDataSources.xcodeproj/xcshareddata/xcschemes/ExampleSSDataSources.xcscheme

+12-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0460"
3+
LastUpgradeVersion = "0800"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -23,10 +23,10 @@
2323
</BuildActionEntries>
2424
</BuildAction>
2525
<TestAction
26+
buildConfiguration = "Debug"
2627
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2728
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
28-
shouldUseLaunchSchemeArgsEnv = "YES"
29-
buildConfiguration = "Debug">
29+
shouldUseLaunchSchemeArgsEnv = "YES">
3030
<Testables>
3131
<TestableReference
3232
skipped = "NO">
@@ -48,17 +48,21 @@
4848
ReferencedContainer = "container:ExampleSSDataSources.xcodeproj">
4949
</BuildableReference>
5050
</MacroExpansion>
51+
<AdditionalOptions>
52+
</AdditionalOptions>
5153
</TestAction>
5254
<LaunchAction
55+
buildConfiguration = "Debug"
5356
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
5457
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
5558
launchStyle = "0"
5659
useCustomWorkingDirectory = "NO"
57-
buildConfiguration = "Debug"
5860
ignoresPersistentStateOnLaunch = "NO"
5961
debugDocumentVersioning = "YES"
62+
debugServiceExtension = "internal"
6063
allowLocationSimulation = "YES">
61-
<BuildableProductRunnable>
64+
<BuildableProductRunnable
65+
runnableDebuggingMode = "0">
6266
<BuildableReference
6367
BuildableIdentifier = "primary"
6468
BlueprintIdentifier = "492A5D07179B29B600A137CC"
@@ -71,12 +75,13 @@
7175
</AdditionalOptions>
7276
</LaunchAction>
7377
<ProfileAction
78+
buildConfiguration = "Release"
7479
shouldUseLaunchSchemeArgsEnv = "YES"
7580
savedToolIdentifier = ""
7681
useCustomWorkingDirectory = "NO"
77-
buildConfiguration = "Release"
7882
debugDocumentVersioning = "YES">
79-
<BuildableProductRunnable>
83+
<BuildableProductRunnable
84+
runnableDebuggingMode = "0">
8085
<BuildableReference
8186
BuildableIdentifier = "primary"
8287
BlueprintIdentifier = "492A5D07179B29B600A137CC"

‎Example/ExampleSSDataSources/Controllers/SSCollectionViewController.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ - (void)viewDidLoad {
6868
target:self
6969
action:@selector(addItem)],
7070
[[UIBarButtonItem alloc] initWithTitle:@"Remove Cell"
71-
style:UIBarButtonItemStyleBordered
71+
style:UIBarButtonItemStylePlain
7272
target:self
7373
action:@selector(removeItem)],
7474

‎Example/ExampleSSDataSources/Supporting Files/ExampleSSDataSources-Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleIcons~ipad</key>
1414
<dict/>
1515
<key>CFBundleIdentifier</key>
16-
<string>net.splinesoft.${PRODUCT_NAME:rfc1034identifier}</string>
16+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1717
<key>CFBundleInfoDictionaryVersion</key>
1818
<string>6.0</string>
1919
<key>CFBundleName</key>

‎Example/ExampleSSDataSourcesTests/SSArrayDataSourceTests.m

+7-1
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,11 @@ - (void)testOutOfBoundsIndexPathAccess
7171

7272
- (void)testSingleTableSectionForItems
7373
{
74+
#pragma clang diagnostic push
75+
#pragma clang diagnostic ignored "-Wnonnull"
7476
SSArrayDataSource *ds = [[SSArrayDataSource alloc] initWithItems:@[@"foo", @"bar"]];
7577
expect([ds numberOfSectionsInTableView:nil]).to.equal(1);
78+
#pragma clang diagnostic pop
7679
}
7780

7881
- (void)testMapsTableRowPerItem
@@ -105,8 +108,11 @@ - (void)testReturnsCellForTableView
105108

106109
- (void)testSingleCollectionSectionForItems
107110
{
111+
#pragma clang diagnostic push
112+
#pragma clang diagnostic ignored "-Wnonnull"
108113
SSArrayDataSource *ds = [[SSArrayDataSource alloc] initWithItems:@[@"foo", @"bar"]];
109114
expect([ds numberOfSectionsInTableView:nil]).to.equal(1);
115+
#pragma clang diagnostic pop
110116
}
111117

112118
- (void)testMapsCollectionItemPerItem
@@ -601,7 +607,7 @@ - (void)testFindingManagedObjectById
601607

602608
- (void)testEmptyView
603609
{
604-
UIView *emptyView = [UIView new];
610+
UIView *emptyView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
605611

606612
dataSource.tableView = (UITableView *)tableView;
607613
dataSource.emptyView = emptyView;

‎Example/ExampleSSDataSourcesTests/SSBaseDataSourceTests.m

+5-5
Original file line numberDiff line numberDiff line change
@@ -196,12 +196,12 @@ - (void)testBasicEmptyViewVisibility
196196
// hidden empty view
197197
SSArrayDataSource *arrayDataSource = [[SSArrayDataSource alloc] initWithItems:@[ @"item" ]];
198198
arrayDataSource.tableView = tableView;
199-
arrayDataSource.emptyView = [UIView new];
200-
expect(arrayDataSource.emptyView.hidden).to.beTruthy();
199+
arrayDataSource.emptyView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
200+
expect(arrayDataSource.emptyView.isHidden).to.beTruthy();
201201

202202
// visible empty view
203203
[arrayDataSource removeAllItems];
204-
expect(arrayDataSource.emptyView.hidden).to.beFalsy();
204+
expect(arrayDataSource.emptyView.isHidden).to.beFalsy();
205205
}
206206

207207
- (void)testEmptyViewSetUpIsNotDependentOnParentViewConfiguration
@@ -211,12 +211,12 @@ - (void)testEmptyViewSetUpIsNotDependentOnParentViewConfiguration
211211
SSArrayDataSource *arrayDataSource;
212212

213213
arrayDataSource = [[SSArrayDataSource alloc] initWithItems:@[]];
214-
arrayDataSource.emptyView = [UIView new];
214+
arrayDataSource.emptyView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
215215
arrayDataSource.tableView = tableView;
216216
expect(arrayDataSource.emptyView.hidden).to.beFalsy();
217217

218218
arrayDataSource = [[SSArrayDataSource alloc] initWithItems:@[]];
219-
arrayDataSource.emptyView = [UIView new];
219+
arrayDataSource.emptyView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
220220
arrayDataSource.collectionView = collectionView;
221221
expect(arrayDataSource.emptyView.hidden).to.beFalsy();
222222
}

‎Example/ExampleSSDataSourcesTests/Supporting Files/ExampleSSDataSourcesTests-Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>${EXECUTABLE_NAME}</string>
99
<key>CFBundleIdentifier</key>
10-
<string>net.splinesoft.${PRODUCT_NAME:rfc1034identifier}</string>
10+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundlePackageType</key>

‎Example/Podfile

+10-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
source 'https://github.com/CocoaPods/Specs.git'
22

33
platform :ios, '6.0'
4+
inhibit_all_warnings!
45

5-
xcodeproj 'ExampleSSDataSources'
6-
7-
pod 'SSDataSources', :path => "../SSDataSources.podspec"
6+
target 'ExampleSSDataSources' do
7+
pod 'SSDataSources', :path => '../'
8+
pod 'MagicalRecord'
9+
10+
target 'ExampleSSDataSourcesTests' do
11+
inherit! :search_paths
812

9-
target :ExampleSSDataSourcesTests, :exclusive => true do
1013
pod 'Expecta'
1114
pod 'OCMock'
12-
pod 'MagicalRecord'
15+
16+
end
1317
end
18+

‎Example/Podfile.lock

+10-8
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,27 @@
11
PODS:
2-
- Expecta (0.4.0)
2+
- Expecta (1.0.5)
33
- MagicalRecord (2.2):
44
- MagicalRecord/Core (= 2.2)
55
- MagicalRecord/Core (2.2)
6-
- OCMock (3.1.2)
6+
- OCMock (3.3.1)
77
- SSDataSources (0.8.5)
88

99
DEPENDENCIES:
1010
- Expecta
1111
- MagicalRecord
1212
- OCMock
13-
- SSDataSources (from `../SSDataSources.podspec`)
13+
- SSDataSources (from `../`)
1414

1515
EXTERNAL SOURCES:
1616
SSDataSources:
17-
:path: "../SSDataSources.podspec"
17+
:path: ../
1818

1919
SPEC CHECKSUMS:
20-
Expecta: 392a6b5bfb9f4097e47dd8064d9b732079490332
21-
MagicalRecord: f8a56bb87ab6552f20c4bb8681a1958a197ea3cd
22-
OCMock: a10ea9f0a6e921651f96f78b6faee95ebc813b92
20+
Expecta: e1c022fcd33910b6be89c291d2775b3fe27a89fe
21+
MagicalRecord: 2dc87179ae7c1f2a274442624ec65a07d4357a6f
22+
OCMock: f3f61e6eaa16038c30caa5798c5e49d3307b6f22
2323
SSDataSources: b01170fb23b82acf0649194e9189b0bf5f702681
2424

25-
COCOAPODS: 0.37.2
25+
PODFILE CHECKSUM: a825c470a277c6414e70013f6c8fb50387acf57d
26+
27+
COCOAPODS: 1.1.1

‎circle.yml

+13-6
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,26 @@ machine:
33
LANG: en_US.UTF-8
44
LC_CTYPE: en_US.UTF-8
55
xcode:
6-
version: "6.3.1"
6+
version: "8.0"
77
dependencies:
88
pre:
9-
- xcrun instruments -w "iPhone 6 (8.3 Simulator)" || exit 0
9+
- xcrun instruments -w 'D0D2EBA2-A0DC-4710-87C5-79DFDBF7E123' || true
1010
override:
1111
- sudo gem install cocoapods xcpretty obcd -N
1212
- pod install --project-directory=Example
1313
test:
1414
override:
15-
- set -o pipefail && xcodebuild -workspace Example/ExampleSSDataSources.xcworkspace
16-
-scheme ExampleSSDataSources -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 6"
17-
GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES clean test | xcpretty -c
18-
--report junit --output ${CIRCLE_TEST_REPORTS}/junit.xml
15+
- set -o pipefail &&
16+
xcodebuild
17+
GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES
18+
GCC_GENERATE_TEST_COVERAGE_FILES=YES
19+
-sdk iphonesimulator
20+
-destination 'platform=iOS Simulator,name=iPhone 6,OS=latest'
21+
-workspace Example/ExampleSSDataSources.xcworkspace
22+
-scheme "ExampleSSDataSources"
23+
clean build test |
24+
tee $CIRCLE_ARTIFACTS/xcode_raw.log |
25+
xcpretty --color --report junit --output $CIRCLE_TEST_REPORTS/junit.xml
1926
- pod lib lint --quick
2027
- obcd --path SSDataSources find HeaderStyle
2128
deployment:

0 commit comments

Comments
 (0)
Please sign in to comment.